Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether it is a bot project folder while opening #4071

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Sep 9, 2020

Description

add one more check while opening a invalid bot project folder.

Using postman to send a put request with {path: "an existing but invalid bot project folder path", storageId: "default"} will return an warning message.

Task Item

closes #3723

Screenshots

@coveralls
Copy link

coveralls commented Sep 9, 2020

Coverage Status

Coverage increased (+0.006%) to 55.5% when pulling 9d7b50f on bug3723 into 2315eeb on main.

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Sep 14, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit 673f961 into main Sep 14, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the bug3723 branch September 14, 2020 20:15
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…t#4071)

Co-authored-by: zeye <zeye@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Composer does not validate the path of a bot project before "opening" it
4 participants