feat: Add endpoint dropdown to the add skill modal #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
reviewed
Sep 16, 2020
srinaath
reviewed
Sep 16, 2020
| @@ -676,16 +670,7 @@ const DesignPage: React.FC<RouteComponentProps<{ dialogId: string; projectId: st | |||
| onSubmit={handleCreateDialogSubmit} | |||
| /> | |||
| )} | |||
| {showAddSkillDialogModal && ( | |||
| <CreateSkillModal | |||
There was a problem hiding this comment.
Can we pass the projectId along with the CreateSkillModal. The reason being when we support multiple bots we are calling the dispatcher function with the project ID rather than fetching the current project ID asynchronously in the dispatcher.
There was a problem hiding this comment.
srinaath
reviewed
Sep 16, 2020
srinaath
approved these changes
Sep 17, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* feat: Add endpoint dropdown to the add skill modal * update duplicate criteria * prject id * updated dispatchers * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an endpoint dropdown to the add skill modal which allows the user to select which messaging endpoint they want to use when they add the skill. The
msAppIdandendpointUrlfor the endpoint the user selects is serialized to theskillsobject in the bot settings with the other skill data -nameandmanifestUrl- provided in the modal.Task Item
Closes #4122
Closes #4087
Screenshots