Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extensions page in settings #4264

Merged
merged 24 commits into from
Sep 29, 2020
Merged

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Adds extensions page that shows installed extensions. Users can search for extensions and install, enable/disable and uninstall.

Task Item

closes #3991

Screenshots

image
image

@coveralls
Copy link

coveralls commented Sep 24, 2020

Coverage Status

Coverage decreased (-0.2%) to 55.449% when pulling 0032175 on abrown/extensions/list-ui into 4714bf2 on main.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Looks great otherwise 👍

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 strings that need to be localized -- other than that looks good 👍

@cwhitten cwhitten merged commit 59f4649 into main Sep 29, 2020
@cwhitten cwhitten deleted the abrown/extensions/list-ui branch September 29, 2020 22:39
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* re-enable extensions page

* support multiple extension pages

* revert to using bundleId for page config

* omit sensitve properties from extension apis

* fix adding new extension to state

* add shimmer list when doing remote calls

* show extension display name

* update search mechanics

Update cache with all results of keyword search and then match on query in memory.

* ensure remote extensions dir exists

* fix api call to get plugin bundle

* spawn npm with shell on windows platforms

* improve searching UX

* show message when no extensions or search results

* add description to extension db

* move uninstall action to toolbar

* use ensureDir api from fs-extra

* memoize callback functions

* fix type error in test

* fix failing tests

* localize some strings

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions page in settings page that lists currently installed plugins
5 participants