-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add extensions page in settings #4264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update cache with all results of keyword search and then match on query in memory.
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
September 24, 2020 21:36
tonyanziano
suggested changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. Looks great otherwise 👍
Composer/packages/client/src/pages/setting/extensions/Extensions.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/extensions/InstallExtensionDialog.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 25, 2020
Composer/packages/client/src/pages/setting/extensions/InstallExtensionDialog.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/extensions/InstallExtensionDialog.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/extensions/InstallExtensionDialog.tsx
Show resolved
Hide resolved
tonyanziano
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 strings that need to be localized -- other than that looks good 👍
Composer/packages/client/src/pages/setting/extensions/ExtensionSearchResults.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/extensions/Extensions.tsx
Outdated
Show resolved
Hide resolved
tonyanziano
approved these changes
Sep 29, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* re-enable extensions page * support multiple extension pages * revert to using bundleId for page config * omit sensitve properties from extension apis * fix adding new extension to state * add shimmer list when doing remote calls * show extension display name * update search mechanics Update cache with all results of keyword search and then match on query in memory. * ensure remote extensions dir exists * fix api call to get plugin bundle * spawn npm with shell on windows platforms * improve searching UX * show message when no extensions or search results * add description to extension db * move uninstall action to toolbar * use ensureDir api from fs-extra * memoize callback functions * fix type error in test * fix failing tests * localize some strings Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds extensions page that shows installed extensions. Users can search for extensions and install, enable/disable and uninstall.
Task Item
closes #3991
Screenshots