Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds UI pivotFieldsets to UI Options #4265

Merged
merged 6 commits into from
Sep 30, 2020
Merged

feat: Adds UI pivotFieldsets to UI Options #4265

merged 6 commits into from
Sep 30, 2020

Conversation

tdurnford
Copy link
Collaborator

@tdurnford tdurnford commented Sep 25, 2020 •
edited
Loading

Description

Adds pivotFieldsets to UI Options. When the ui options has a fieldset and pivotField is true, the fieldset is rendered in a tabbed view.

This PR also updates the prompts ui-plugin to leverage fieldsets and additionalFields instead of custom fields.

Task Item

Closes #3588

@tdurnford tdurnford closed this Sep 29, 2020
@tdurnford tdurnford reopened this Sep 29, 2020
@tdurnford tdurnford marked this pull request as ready for review September 29, 2020 21:38
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 55.639% when pulling edc8fb0 on tdurnford:feature/pivot-field-sets into 4714bf2 on microsoft:main.

@coveralls
Copy link

coveralls commented Sep 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 55.4% when pulling 589b4a7 on tdurnford:feature/pivot-field-sets into 51c59a9 on microsoft:main.

a-b-r-o-w-n
a-b-r-o-w-n requested changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! Let's make sure this gets added to the upstream ui schema definition as well.

Composer/packages/adaptive-form/src/AdaptiveFormContext.ts Outdated Show resolved Hide resolved
@a-b-r-o-w-n a-b-r-o-w-n merged commit 87477bc into microsoft:main Sep 30, 2020
@tdurnford tdurnford deleted the feature/pivot-field-sets branch September 30, 2020 18:01
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tdurnford
feat: Adds UI pivotFieldsets to UI Options (microsoft#4265)
146b05e 
* pivot field sets

* add jsx

* updated type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

@LouisEugeneMSFT LouisEugeneMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support fieldsets in ui schema
4 participants
@tdurnford @coveralls @a-b-r-o-w-n @LouisEugeneMSFT