fix: Monaco editor links opened in blank window in electron #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
previously requested changes
Sep 25, 2020
a-b-r-o-w-n
reviewed
Sep 25, 2020
cwhitten
approved these changes
Sep 25, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 28, 2020
* main: fix: Monaco editor links opened in blank window in electron (microsoft#4269) feat: add notification center for composer (QnA url import) (microsoft#4080) fix: Object examples not properly displayed as placeholders (microsoft#4126) fix: allows spaces in bot project path (microsoft#4260) chore: extract build logic from components page (microsoft#4153)
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: Monaco editor links opened in blank window in electron (microsoft#4269) feat: add notification center for composer (QnA url import) (microsoft#4080) fix: Object examples not properly displayed as placeholders (microsoft#4126) fix: allows spaces in bot project path (microsoft#4260) chore: extract build logic from components page (microsoft#4153)
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: fix: Monaco editor links opened in blank window in electron (#4269) feat: add notification center for composer (QnA url import) (#4080) fix: Object examples not properly displayed as placeholders (#4126) fix: allows spaces in bot project path (#4260) chore: extract build logic from components page (#4153)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#4269) * disable ctrl + click open window in electron * do not use hasOwnProperty * cast window to any Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Monaco editor has option config to auto detect urls in text. ctrl + click on it will call vscode.open() -> window.open() open url.
Our current electron setting can handle
<a target="_blank">open in browser</a>, but electron@8.2.4 seems has issue accept correct arguments. then we will see a empty page, case the accepted argumentsurlisabout:blank.Alternative solution
If we upgrade electron@10.1.1, the electron opened window would be correctly, but still failed to open in default browser.
Current solution
So before find a better way, current fix is disable link detecting in BaseEditor.text for electron environment.
Task Item
close #4070
Screenshots
Before (electron):
After (electron):