feat: Updating uiSchema in Composer #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisEugeneMSFT
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
carlosscastro,
cwhitten,
GeoffCoxMSFT,
hatpick,
luhan2017,
srinaath and
tonyanziano
as code owners
|
@LouisEugeneMSFT are these ui schema changes also ported into the component ui schemas? |
|
@cwhitten those were updated in microsoft/botbuilder-dotnet#4704 |
a-b-r-o-w-n
approved these changes
Oct 16, 2020
cwhitten
approved these changes
Oct 16, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Those changes enable Intellisense to leverage the uiSchema in order to know what type of completion items to show.
Step 1 was modifying the schema of the uiSchema: microsoft/botframework-sdk#6047
Step 2 was updating the uiSchema of individual components: microsoft/botbuilder-dotnet#4704
Step 3 was updating Composer to leverage the uiSchema for Intellisense: #4263
This final step is to update Composer's uiSchema itself.
The schema was generated running bf dialog:merge "libraries//*.schema" "libraries//*.uischema" from botbuilder-dotnet
Task Item
fixes #4187
fixes #4189
Screenshots
Intellisense:
Example of schema change:
