feat: Added trigger grouping methods to indexers #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
GeoffCoxMSFT
changed the title
hatpick
reviewed
Oct 17, 2020
| export const extractSchemaProperties = (dialog: DialogInfo, jsonSchemaFiles: JsonSchemaFile[]): string[] => { | ||
| if (dialog.content?.schema) { | ||
| const schema = jsonSchemaFiles.find( | ||
| (file) => file.id === getBaseName(dialog.content.schema) || file.id === dialog.content.schema |
There was a problem hiding this comment.
The build caught that too :) Fortunately, it helped me find another missing case to handle.
hatpick
approved these changes
Oct 19, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added trigger grouping methods to indexers * Fix bug and build issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added indexer method to support to grouping triggers by property.
Supports 3 ways to determine the properties associated with a trigger:
This association spans the trigger and its actions.
The grouping algorithm supports
Added indexer method to support extracting the schema property names from a dialog with a schema property. This prefers the properties under $public, but falls back to all properties.
Task Item
#minor
#4150
Screenshots
While the project tree isn't in main yet, this demonstrates that a form with a schema can be identified as a form dialog, and the triggers can be grouped by property.