Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SwitchCondition's path cannot be parsed correctly #4489

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Oct 23, 2020

Description

#minor

When clicking on a child action under a case of SwitchCondition, Composer will redirect to root dialog.

This is caused by the data path triggers["nPWg4L"].actions["CSz3HO"].cases[0].actions["r3Mhiy"] cannot be recognized by url decoder.

Previously, the url decoder only supports pure index-based format or pure designer-based format. This PR lets the decoder support a mixed format data path.

Task Item

Screenshots

@coveralls
Copy link

coveralls commented Oct 23, 2020

Coverage Status

Coverage increased (+0.03%) to 55.263% when pulling 1713b64 on yeze322:url/mixed-mode into fa0b039 on microsoft:main.

@cwhitten cwhitten merged commit e447bf6 into microsoft:main Oct 23, 2020
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants