fix: Check the name without a number at the beginning when creating a new dialog #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
zhixzhan
reviewed
Oct 23, 2020
boydc2014
previously approved these changes
Oct 23, 2020
boydc2014
previously approved these changes
Oct 23, 2020
cwhitten
approved these changes
Oct 23, 2020
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
… new dialog (microsoft#4493) * fix: Check the dialog name without a number at the beginning when creating * add validate to the shared * fix unit test Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
closes #4246
Screenshots