fix: Expressions not starting with "=" can resolve to a regular TextField #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisEugeneMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
| // "expression" inputs don't leverage the built-in functions. For those, we only want to show a regular text field (that could potentially leverage Intellisense for results other than built-in expression functions). | ||
| if (value.startsWith('=')) { | ||
| return { field: isOneOf ? DefaultFields.IntellisenseExpressionField : IntellisenseExpressionFieldWithIcon }; | ||
| } else { |
There was a problem hiding this comment.
Nit: Could merge else and else if to just else ifs
GeoffCoxMSFT
approved these changes
Oct 23, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ield (microsoft#4507) * Expressions not starting with "=" can resolve to a regular TextField * Update comment Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolveFieldWidget assumed that all expressions start with "=". But there are two types of expressions:
As such, schema types that were oneOf between expression (not equalsExpression) and a list of non string types were enable to resolve when the input was a string. Such an example is condition:
This PR addresses this issue by resolving to a regular input field when the type is an expression.
Task Item
fixes #4479
Screenshots