perf: avoid redraw when Project Tree selected item not changed #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
yeze322
force-pushed
the
perf/projecttree
branch
from
6d881a6
to
d484e0a
Compare
srinaath
reviewed
Oct 28, 2020
| @@ -206,6 +206,9 @@ export const ProjectTree: React.FC<Props> = ({ | |||
| }; | |||
|
|
|||
| const handleOnSelect = (link: TreeLink) => { | |||
| // Skip state change when link not changed. | |||
| if (isEqual(link, selectedLink)) return; | |||
srinaath
approved these changes
Oct 28, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 5, 2020
* settingsPage: (110 commits) code style update qna end point key after update qna subscription key handle comments handle comments chore: remove orchestrator (microsoft#4602) feat: taking control recognizer generation enhancements (microsoft#4549) chore: Set up Nightly static analysis pipeline in ADO (microsoft#4589) feature: show multi-skill project with correct link behavior (microsoft#4466) doc: guidelines/help-contents (microsoft#4354) Functions runtime: Revert to netcore3.0 for functions and make code more robust to functions variations (microsoft#4570) feat: Disable Connect to Skill menu action inside skill (microsoft#4557) fix (microsoft#4591) fix: Adds validation for form dialogs propery name (microsoft#4574) fix: update archive version in extensions/vacore (microsoft#4571) fix: e2e test (microsoft#4581) perf: avoid redraw when Project Tree selected item not changed (microsoft#4564) fix: security analysis failure due to bl package version (microsoft#4580) fix publish ut timeout (microsoft#4578) fix: Can not add properties in "SetProperties" action (microsoft#4572) ci: remove code scanning workflow (microsoft#4569) ...
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…soft#4564) * skip state changes when project tree not changed * remove experimental code Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#minor
Avoid redraw when Project Tree selected item not changed by comparing prev and new links.
Task Item
Screenshots