Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve the root files when creating a PVA bot #4611

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Nov 2, 2020

Description

This is the #4520 's follow up. In #4520 we only preserve the root dialog. The lu and lg also can't be updated when precerveRoot is true.

  1. preserve the root lu and lg file.
  2. update the id in root dialog content.
  3. update the recognizer generate

Task Item

#minor
#refs #4520

Screenshots

@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage increased (+0.04%) to 55.134% when pulling fcece37 on lei9444:pvatest into 44f841a on microsoft:main.

@cwhitten cwhitten merged commit 3acc597 into microsoft:main Nov 2, 2020
luhan2017 pushed a commit that referenced this pull request Nov 3, 2020
* fix: preserve the root file when create a PVA bot

* remove lowercase

* update the designer

* fix e2e test
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
@lei9444 lei9444 deleted the pvatest branch February 1, 2021 02:07
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: preserve the root file when create a PVA bot

* remove lowercase

* update the designer

* fix e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants