Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account for undefined $designer in breadcrumb #4752

Merged
merged 2 commits into from
Nov 10, 2020
Merged

fix: account for undefined $designer in breadcrumb #4752

merged 2 commits into from
Nov 10, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Fixes an issue where the designer cannot load because a trigger does not have $designer.

Task Item

fixes #4750

beyackle
beyackle approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I was about to do.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.292% when pulling 040633f on abrown/gh-4750 into 0ab4c79 on main.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 17e01fa into main Nov 10, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/gh-4750 branch November 10, 2020 23:39
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n
fix: account for undefined $designer in breadcrumb (microsoft#4752)
7c3a402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@beyackle beyackle beyackle approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot load designer if $designer field undefined in dialog data
4 participants
@a-b-r-o-w-n @coveralls @cwhitten @beyackle