feat: Polling creation process #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added backgroundprocessmanager as a service used for process tracking Added routing to the controller
… back end Refactoring exisitng endpoint for code sharing
pavolum
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Nov 13, 2020
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/services/backgroundProcessManager.ts
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Nov 14, 2020
| const timer = setInterval(async () => { | ||
| try { | ||
| const response = await httpClient.get(`/status/${jobId}`); | ||
| if (response.data?.httpStatusCode === 200 && response.data.result && response.data.result != {}) { |
There was a problem hiding this comment.
What is the last condition for? Why isn't it strict equality?
Removed unnecessary check
hatpick
approved these changes
Nov 17, 2020
hatpick
approved these changes
Nov 17, 2020
GeoffCoxMSFT
approved these changes
Nov 17, 2020
EricDahlvang
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Added status controller for front end process status queries Added backgroundprocessmanager as a service used for process tracking Added routing to the controller * Cleaning up unused aspects of ported polling pattern * creating new 'create bot' server endpoint for new creation experinece back end Refactoring exisitng endpoint for code sharing * scaffolding new creation backend flow * Implemented new backend creation flow with polling * minor bug fix * Stronger typing and minor clean up * minor changes for clean 'yarn typecheck' * Fixing server response status and nit clean up * foxing return statement * Update project.ts Removed unnecessary check Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* Added status controller for front end process status queries Added backgroundprocessmanager as a service used for process tracking Added routing to the controller * Cleaning up unused aspects of ported polling pattern * creating new 'create bot' server endpoint for new creation experinece back end Refactoring exisitng endpoint for code sharing * scaffolding new creation backend flow * Implemented new backend creation flow with polling * minor bug fix * Stronger typing and minor clean up * minor changes for clean 'yarn typecheck' * Fixing server response status and nit clean up * foxing return statement * Update project.ts Removed unnecessary check Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Added status controller for front end process status queries Added backgroundprocessmanager as a service used for process tracking Added routing to the controller * Cleaning up unused aspects of ported polling pattern * creating new 'create bot' server endpoint for new creation experinece back end Refactoring exisitng endpoint for code sharing * scaffolding new creation backend flow * Implemented new backend creation flow with polling * minor bug fix * Stronger typing and minor clean up * minor changes for clean 'yarn typecheck' * Fixing server response status and nit clean up * foxing return statement * Update project.ts Removed unnecessary check Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added status controller for front end process status queries Added backgroundprocessmanager as a service used for process tracking Added routing to the controller * Cleaning up unused aspects of ported polling pattern * creating new 'create bot' server endpoint for new creation experinece back end Refactoring exisitng endpoint for code sharing * scaffolding new creation backend flow * Implemented new backend creation flow with polling * minor bug fix * Stronger typing and minor clean up * minor changes for clean 'yarn typecheck' * Fixing server response status and nit clean up * foxing return statement * Update project.ts Removed unnecessary check Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following:
It would be minimal work to light up this 'pollable' creation endpoint for all templates and remove the introduced redundant code, however in R12 the creation work will need this separation and scaffolding as it will significantly alter the creation flow. This method also has very little impact on the core creation flows prior to a release.
Task Item
fixes #4805
Screenshots