feat: telemetry api #4968
Merged
feat: telemetry api #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Nov 24, 2020
a-b-r-o-w-n
requested changes
Nov 30, 2020
There was a problem hiding this comment.
I think I'd like to see the server API support event batching instead of processing singular events since the payloads are small.
The client should then implement a pooling mechanism that processes the events in batches of 10 or 20. This will allow the client-side telemetry to scale better.
Some things to consider with this approach:
- Set an interval to process all events in queue (like you have now, but call
flushevery n seconds). - Be sure to drain the queue when navigating away from the page.
Also, I might have missed this, but is logPageView being called anywhere?
|
@a-b-r-o-w-n No, |
a-b-r-o-w-n
reviewed
Dec 2, 2020
a-b-r-o-w-n
reviewed
Dec 2, 2020
| break; | ||
| } | ||
| } catch (error) { | ||
| // swallow the exception on a failed attempt to collect usage data |
There was a problem hiding this comment.
consider adding in retry logic here and in the client.
a-b-r-o-w-n
requested changes
Dec 3, 2020
a-b-r-o-w-n
previously approved these changes
Dec 3, 2020
a-b-r-o-w-n
approved these changes
Dec 3, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* feat: telemetry api * lint * persist machine id * move telemetry settings to user settings * reverted changes to en-US * pool telemetry events * changed batch size * fix uuid * add telemetry classes * requested changes * shorted interval * fix integration test * change parameter type Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for telemetry api in the client and the server. Also adds the hashed mac address to the electron context.
Task Item
Closes #4765