Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: todoluissamples start failure #5101

Merged
merged 6 commits into from
Dec 4, 2020
Merged

fix: todoluissamples start failure #5101

merged 6 commits into from
Dec 4, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Dec 4, 2020

Description

This is a regression by some feature branch merge:
CrossTain config contains the empty lu files, but sever filters the empty files. crosstrain api will throw error when no lu file find.

Task Item

refs #4961
closes #5099

Screenshots

@coveralls
Copy link

coveralls commented Dec 4, 2020

Coverage Status

Coverage increased (+0.01%) to 55.671% when pulling f4d5247 on lei9444:fixlu into 8cba0f5 on microsoft:main.

@boydc2014 boydc2014 changed the title fix: todoluissamples start failed when doing cross train fix: todoluissamples start failure Dec 4, 2020
@boydc2014 boydc2014 merged commit 2a5d599 into microsoft:main Dec 4, 2020
@lei9444 lei9444 deleted the fixlu branch February 1, 2021 02:06
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: todoluissamples start failed when doing cross train

* fix e2e test

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToDoLuisSample's can't start if clicked help dialog
3 participants