Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow manifest creation on root bot #5116

Merged
merged 6 commits into from
Dec 6, 2020

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Dec 4, 2020

Description

Allow manifest creating,editing on Root bot and skills. The view mode of the manifest is not required in the Project tree. It is only required inside the property editor pane of Connect to skill action

Fixes #5082 

@zhixzhan

Srinaath Ravichandran added 2 commits December 4, 2020 11:14
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath added the BotProjects Group all Bot projects tickets label Dec 4, 2020
@srinaath srinaath added this to the R11 milestone Dec 4, 2020
@srinaath srinaath added the 1.3 1.3 Release label Dec 4, 2020
@coveralls
Copy link

coveralls commented Dec 4, 2020

Coverage Status

Coverage remained the same at 55.474% when pulling 1f6af1c on srravich/bugfix-allow-manifest-creation into 90ec7cc on main.

@cwhitten cwhitten merged commit 694c50f into main Dec 6, 2020
@cwhitten cwhitten deleted the srravich/bugfix-allow-manifest-creation branch December 6, 2020 02:49
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Allow manifest creation on rootbot

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* remove unused refs

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3 1.3 Release BotProjects Group all Bot projects tickets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skill manifest creation for the root bot
3 participants