Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skill bot missing skill diagnostics #5218

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 8, 2020

Description

The bug is caused not set botProjectFileState for skill bot when do open local skill.

Task Item

close #5211

Screenshots

image

@coveralls
Copy link

coveralls commented Dec 8, 2020

Coverage Status

Coverage increased (+0.003%) to 55.323% when pulling 3fea7cf on zhixzhan/skillbot-projfile-fix into 547f604 on main.

@lei9444
Copy link
Contributor

lei9444 commented Dec 8, 2020

Tested it and LGTM

@boydc2014 boydc2014 merged commit 796081a into main Dec 8, 2020
@boydc2014 boydc2014 deleted the zhixzhan/skillbot-projfile-fix branch December 8, 2020 11:19
@Samirun
Copy link

Samirun commented Dec 15, 2020

@zhixzhan
yesterday release of bot composer 1.3.0 is done due to which few things have changed
some basic information: i was trying to export a skill bot and connect to that bot within another bot 
by following documentation https://docs.microsoft.com/en-us/composer/how-to-export-a-skill.
Problem: how to connect to a skill and how to use skill host end points  for local testing with the recent changes? documentation is not updated and it seems it takes time.
 
Steps to Reproduce issue:
i have created 2 bots and generated manifest for skill bot and tried to use it in the consumer bot 
with recent changes i don't find any place where i could use skill manifest json of a bot  as a skill in any  consumer bot.
documentation https://docs.microsoft.com/en-us/composer/how-to-connect-to-a-skill  says : Still on the Skills page, select + Connect to a new skill on the upper left corner of the toolbar to show the Add a skill windows."
now the problem is how to move forward from this step within bot composer 1.3.0?  i am unable to select " skill dialog name" and  "skill end point".
image

Changes observed : 
1)skill host endpoint  previously used to be like  http://localhost:3983/api/messages now changed to  http://localhost:3980/api/skills
 
2) there used to be a skill section in UI where we can connect to another skill  using skill manifest json file of a sill bot as mentioned in the documentation
https://docs.microsoft.com/en-us/composer/how-to-connect-to-a-skill
QUESTIONS : 
1)as the 1.3.0 release is few hours old  i need some quick guidance  over here how to use a skill bot in another consumer bot.
2)is there any alternative to export skill as a manifest ?  we need some quick solution to this problem

lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* set botProjectFileState for skill bot

* update hint text

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a skill to a root bot which was a root bot in a different context
5 participants