fix: Start bots optimization #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
cwhitten
approved these changes
Dec 10, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles an unnecessary check that forces us to clear the hosted bots folder. Copy the bot again. Rebuild all the dependnacies every run.
@luhan2017 @VanyLaw can u help me evaluate if this change is OK. I have tried ejecting C# runtime and non ejected scenarios all of them seem to work fine. It seems to have been introduced here https://github.com/microsoft/BotFramework-Composer/pull/3198/files#diff-8bc80526cd9185a7138ca77498899908f213e41c98bfc7852a05a9e3c4fca37cR247
Fixes #5191