Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate responses #5299

Merged
merged 4 commits into from
Dec 11, 2020
Merged

fix: generate responses #5299

merged 4 commits into from
Dec 11, 2020

Conversation

GeoffCoxMSFT
Copy link
Member

Description

  • updated to track errors during and success of generate call
  • return reduces payload for generate and deleteDialog (project ID rather than entire project)
  • update to add logs to form dialog error state

Task Item

Closes #5295

Screenshots

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Dec 10, 2020
@coveralls
Copy link

coveralls commented Dec 10, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 55.271% when pulling ee3dc84 on gcox/improve-formdialog-responses into 3de90be on main.

@GeoffCoxMSFT GeoffCoxMSFT merged commit 86599f8 into main Dec 11, 2020
@GeoffCoxMSFT GeoffCoxMSFT deleted the gcox/improve-formdialog-responses branch December 11, 2020 00:06
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@GeoffCoxMSFT @hatpick
fix: generate responses (microsoft#5299)
253a2d6 
* fix: generate responses

* PR fix

Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatpick hatpick hatpick approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@hatpick hatpick

@GeoffCoxMSFT GeoffCoxMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composer server should return error information for form dialog generation
3 participants
@GeoffCoxMSFT @coveralls @hatpick