fix: use dropdown for LUIS region in skill bot settings #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
Note to reviewers: "FieldWithCustomButton" is a renamed and edited version of "TextFieldWithCustomButton", but for some reason Git didn't track the change as a renaming, so it looks like it's all new. |
cwhitten
approved these changes
Dec 11, 2020
alanlong9278
added a commit
that referenced
this pull request
Dec 17, 2020
* main: (22 commits) fix: Added missing dependencies to /types and /extensions packages. (#4436) fix: Updated publish extensions to use updated APIs (#5346) docs: Supported/Recommended OS Documentation (#5330) chore: suppress/fix lgtm alerts (#4678) v1.3.0 release: update changelog release: update changelog github user map RC5 (#5327) fix: security analysis failed because of ini@1.3.5 (#5326) fix: undo failed after click create trigger and remove trigger (#5325) fix: LG diagnostics mismatch by update reference in cache (#5323) fix: Start panel open on start/restart operation (#5322) fix sentence wrap bug (#5310) fix: use dropdown for LUIS region in skill bot settings (#5318) chore: Updated to latest lib (#5316) feat: provisioning in app (#4221) surface dotnet build error on runtime (#5314) fix: runtime throw exception when there is no cosmosdb config (#5313) chore: Remove onnxruntime.pdb from Publishing (#5291) fix UX bug in setting page (#5306) ...
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* start making field generic * Create FieldWithCustomButton.tsx * refactoring and spelling fix * move props and use generic field Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Project Settings page had a dropdown to choose the LUIS region in the root bot, but not the skill bots. This fixes that by changing TextFieldWithCustomButton into a slightly more generic component that will detect if it's been passed an "options" array and render as a Dropdown instead.
Task Item
closes #5296
Screenshots