fix: ARM token for provisioning is now passed via body. #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick and
srinaath
as code owners
tonyanziano
commented
Apr 5, 2021
| @@ -48,7 +46,7 @@ export const ProvisionController = { | |||
| // call the method | |||
| const result = await pluginMethod.call( | |||
| null, | |||
| { ...req.body, accessToken }, | |||
| { ...req.body }, | |||
There was a problem hiding this comment.
req.body.accessToken now contains the ARM token
cwhitten
approved these changes
Apr 5, 2021
cwhitten
added a commit
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some users were seeing a 431 HTTP response when attempting to provision Azure resources.
This applies the same fix from #5700 to the provisioning endpoint.
Task Item
#minor