-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: Transcript and Activity render speed #5183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
commented
May 10, 2024
OEvgeny
commented
May 10, 2024
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
May 15, 2024 22:56
compulim
reviewed
May 16, 2024
compulim
reviewed
May 16, 2024
compulim
reviewed
May 16, 2024
compulim
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. You now know the internals of our chat history. It's one of the most complex parts of Web Chat.
Let's timebox some time and understand why some snapshots need to be updated. Our snapshots tell us a lot more than we understand. They are our teachers. 👨🏻🏫
Co-authored-by: William Wong <compulim@users.noreply.github.com>
compulim
approved these changes
May 16, 2024
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
BasicTranscript
, in PR 5183, by @OEvgenyuseActivitiesWithRenderer
, in PR 5183, by @OEvgenyDescription
Improve performance by more carefully memoizing activity-related components. Rework the
useMemoAll
hook into the newuseMemoized
hook exposing the memoized function to be used during render phase.Design
The main changes driving the performance boost are:
TranscriptActivity
to memoize everything we want to reuse for activity inside of a single componentrenderingElements
an array of React nodes, so it could be directly returned from rendermemo
when children are not changingSpecific Changes
BasicTranscript
improvementsmemo
for activity related componentsuseMemoAll
and replace withuseMemoized
useMemoized
TranscriptActivity
component-
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)