Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detection of files via import resolution, use static glob and npmignore #788

Merged
merged 67 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
82431ea
Some progress
jakebailey Oct 22, 2023
4b69bc5
Make prettier happier
jakebailey Oct 23, 2023
fad3203
I'm sick of ts-jest warnings
jakebailey Oct 23, 2023
c48ad17
Shifting, but it broke
jakebailey Oct 24, 2023
8f996b8
Drop todo, async hard
jakebailey Oct 24, 2023
2d45701
Add rule
jakebailey Oct 25, 2023
09fd107
Starting some testing
jakebailey Oct 26, 2023
47a9344
maybe fix pos info
jakebailey Oct 26, 2023
05b3379
Disable error reporting for now, files array is no good
jakebailey Oct 26, 2023
b56bd29
Off by one
jakebailey Oct 26, 2023
79e5389
It works
jakebailey Oct 26, 2023
e2bf963
More temp removal
jakebailey Oct 26, 2023
b84884d
better messaging
jakebailey Oct 26, 2023
5cdb31f
Move no-import-of-dev-dependencies to fixtures
jakebailey Oct 26, 2023
2b99dab
Silence jest
jakebailey Oct 26, 2023
beb5ec2
Move no-self-import to new fixtures
jakebailey Oct 26, 2023
9ce00dd
Fix name of test
jakebailey Oct 26, 2023
e952bca
Move no-declare-current-package to new fixtures
jakebailey Oct 26, 2023
77590a3
Test utils
jakebailey Oct 26, 2023
8f02788
Improvements
jakebailey Oct 27, 2023
050ab17
Move to npmignore
jakebailey Oct 27, 2023
a4384ca
TODO
jakebailey Oct 27, 2023
b8d7493
missing change
jakebailey Oct 27, 2023
df63da3
tweak helper
jakebailey Oct 27, 2023
dd4a607
Remove old test
jakebailey Oct 27, 2023
a22273b
Unused import
jakebailey Oct 27, 2023
2a957b6
Remove old test
jakebailey Oct 27, 2023
5e2bd4a
Resolve TODOs
jakebailey Oct 27, 2023
47c7e04
Merge branch 'glob-files' into npmignore
jakebailey Oct 27, 2023
3d6a641
Cleanups, improvements
jakebailey Oct 27, 2023
df7ff30
Fix eslintignore
jakebailey Oct 27, 2023
5f7d7a4
So long module resolution
jakebailey Oct 27, 2023
7ceb05a
More tests
jakebailey Oct 27, 2023
530e030
Scoped variant
jakebailey Oct 27, 2023
28288fd
Use isDeclarationPath more
jakebailey Oct 27, 2023
ec6c833
Assert that OTHER_FILES does not exist
jakebailey Oct 27, 2023
59ecf45
Merge branch 'master' into npmignore
jakebailey Oct 30, 2023
bccb217
Port no-bad-reference to fixture so I can test the other rule with it
jakebailey Oct 30, 2023
bbc1cc2
Make no-relative-references disallow path references in tests
jakebailey Oct 30, 2023
9f70208
Move new rule back into old rule
jakebailey Oct 30, 2023
003b856
Rename
jakebailey Oct 30, 2023
a34c5c9
Prevent refs from escaping, even if they resolve to the same package
jakebailey Oct 30, 2023
e1ecf7a
Remove helper
jakebailey Oct 30, 2023
b4e51e9
TODOs
jakebailey Oct 30, 2023
f63dd44
TODOs, ban slashes
jakebailey Oct 30, 2023
fb5a380
Merge branch 'master' into npmignore
jakebailey Oct 30, 2023
0430b74
Remove dead test
jakebailey Oct 30, 2023
82c3a3d
Merge branch 'master' into npmignore
jakebailey Oct 30, 2023
6fb7f6c
fmt
jakebailey Oct 30, 2023
3927f8d
Changeset
jakebailey Oct 31, 2023
705c0ab
More ellaborate changeset
jakebailey Oct 31, 2023
1e321fa
Merge branch 'master' into npmignore
jakebailey Oct 31, 2023
b84865e
Merge branch 'master' into npmignore
jakebailey Oct 31, 2023
7b1d440
Undo leftover change
jakebailey Oct 31, 2023
f945014
Consolidate logic for types package prefix
jakebailey Oct 31, 2023
29bce41
One more use
jakebailey Oct 31, 2023
aa23f5e
Rename
jakebailey Oct 31, 2023
656b019
Merge branch 'master' into npmignore
jakebailey Nov 1, 2023
6f45d35
Inline constant (it used to be more complicated)
jakebailey Nov 1, 2023
a869d6e
Remove unused comment
jakebailey Nov 1, 2023
435921f
Move Reference up
jakebailey Nov 1, 2023
e2aba74
PR feedback
jakebailey Nov 1, 2023
7e2a8ea
Merge branch 'master' into npmignore
jakebailey Nov 1, 2023
4b3f361
Fix no-declare-current-package and improve tests
jakebailey Nov 1, 2023
ee4f887
Merge branch 'master' into npmignore
jakebailey Nov 6, 2023
817d149
Update content hash to sort package.json, no BOM check
jakebailey Nov 6, 2023
0f45bff
Ban BOM via eslint
jakebailey Nov 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,11 @@ dist
*.tsbuildinfo
*.lerna_backup
packages/utils/cache
.pnpm-store
.pnpm-store


**/.vscode/*
!**/.vscode/tasks.json
!**/.vscode/settings.template.json
!**/.vscode/launch.json
!**/.vscode/extensions.json
7 changes: 7 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
node_modules
dist
packages/publisher/output

packages/dts-critic/testsource

*.json
*.yml
*.yaml
*.md
File renamed without changes.
15 changes: 9 additions & 6 deletions jest.config.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
module.exports = {
preset: "ts-jest",
testEnvironment: "node",
modulePathIgnorePatterns: ["packages\\/publisher\\/output"],
modulePathIgnorePatterns: ["packages\\/publisher\\/output", "testsource", "fixtures"],
testMatch: ["<rootDir>/packages/*/test/**/*.test.ts", "<rootDir>/packages/dts-critic/index.test.ts"],
transform: {
"^.+\\.tsx?$": ["ts-jest", {
tsconfig: "<rootDir>/tsconfig.test.json",
diagnostics: false
}]
}
"^.+\\.tsx?$": [
"ts-jest",
{
tsconfig: "<rootDir>/tsconfig.test.json",
diagnostics: false,
},
],
},
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"eslint-plugin-jsdoc": "^30.7.8",
"jest": "^29.5.0",
"prettier": "^2.6.2",
"ts-jest": "^29.0.5",
"ts-jest": "^29.1.1",
"tslint": "^6.1.2",
"tslint-microsoft-contrib": "^6.2.0",
"typescript": "^5.2.2"
Expand Down
Loading
Loading