Bump version to 3.1.1 & Adjust title level in README #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyca15
reviewed
Dec 7, 2023
README.md
Outdated
| @@ -141,7 +144,7 @@ A `RequirementType` of `All` changes the traversal. First, if there are no filte | |||
|
|
|||
| In the above example, `FeatureW` specifies a `RequirementType` of `All`, meaning all of it's filters must evaluate to true for the feature to be enabled. In this case, the feature will be enabled for 50% of users during the specified time window. | |||
|
|
|||
| ### Service Registration | |||
| ## Service Registration | |||
There was a problem hiding this comment.
I think the root title should be Consumption and then it goes over featureManager.IsEnabledAsync right away.
Then it Service Registration, and DI can be following subsections.
Feature check section would no longer be needed.
And I'd suggest moving the scoped services section last in the Consumption parent section.
So
Consumption (Immediate text replaces feature check section)
- Service Registration
- Dependency Injection
- Scoped Feature Management Services
jimmyca15
reviewed
Dec 7, 2023
README.md
Outdated
| @@ -439,7 +447,7 @@ public void ConfigureServices(IServiceCollection services) | |||
| **Advanced:** `IHttpContextAccessor`/`HttpContext` should not be used in the Razor components of server-side Blazor apps. [The recommended approach](https://learn.microsoft.com/en-us/aspnet/core/blazor/security/server/interactive-server-side-rendering?view=aspnetcore-7.0#ihttpcontextaccessorhttpcontext-in-razor-components) for passing http context in Blazor apps is to copy the data into a scoped service. For Blazor apps, `AddScopedFeatureManagement` should be used to register the feature management services. | |||
| Please refer to the `Scoped Feature Management Services` section for more details. | |||
|
|
|||
| ## Providing a Context For Feature Evaluation | |||
| ### Providing a Context For Feature Evaluation | |||
There was a problem hiding this comment.
I don't consider this a subsection of implementing a filter.
There was a problem hiding this comment.
And perhaps the built-in filters section should be promoted a level.
jimmyca15
approved these changes
Dec 12, 2023
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/adjust-readme-title-level
branch
from
76da523
to
2697fa8
Compare
zhiyuanliang-ms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.