Adds AppInsightsTelemetryConsumer, new app-insights export subpath and README updates. #20479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
…d README updates.
github-actions
bot
added
the
dependencies
alexvy86
approved these changes
Apr 5, 2024
Comment on lines
64
to
66
| Congrats, that's it for now! If you've decided to use Azure App Insights, we have designed useful prebuilt queries for you that utilize the generated telemetry | ||
|
|
||
| Before you can get telemetry sent to Azure App Insights, you'll need to create an Instance of App Insights on Azure. Then you'll be able to create an Azure App Insights client that you can easily turn into a ITelemetryConsumer and finally hook it up to container telemetry. [Learn more about Azure App Insights](https://learn.microsoft.com/en-us/azure/azure-monitor/app/app-insights-overview) | ||
| **It's important to note that while you can create your own custom implementation of `ITelemetryConsumer` for sending telemetry to App Insights, if you change the shape of the telemetry emitted from our implementation, `AppInsightsTelemetryConsumer`, we make no guarentess of our provided App Insights queries or dashboards working as expected.** |
There was a problem hiding this comment.
Let's remove this bit and add it when the queries are here?
|
|
||
| ### Step 1: Install the @fluidframework/fluid-telemetry package and Azure App Insights package dependencies | ||
| ## Example 2: Extending ITelemtryConsumer to send Fluid telemetry to a custom destination |
There was a problem hiding this comment.
Typo
Suggested change
| ## Example 2: Extending ITelemtryConsumer to send Fluid telemetry to a custom destination | |
| ## Example 2: Extending ITelemetryConsumer to send Fluid telemetry to a custom destination |
| class AppInsightsTelemetryConsumer implements ITelemetryConsumer { | ||
| constructor(private readonly appInsightsClient: ApplicationInsights) {} | ||
|
|
||
| // 2: This is our implementation of ITelemetryConsumer |
There was a problem hiding this comment.
Probably remove section 2 here, since Step 2 above has this same class definition?
There was a problem hiding this comment.
I see how that might be confusing. I've updated the example to be as if you're imported the implementation from another file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AppInsightsTelemetryConsumerto the package and exports it under a new subpath/app-insights