-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect better stats for snapshot loading (SPO) #20481
Conversation
⯅ @fluid-example/bundle-size-tests: +254 Bytes
Baseline commit: 7829364 |
for (const [_, tree] of Object.entries(snapshotTree.trees)) { | ||
numTrees += 1; | ||
numTrees += countTreesInSnapshotTree(tree); | ||
function getTreeStatsCore(snapshotTree: ISnapshotTree, stats: ITreeStats): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: suggestion to place the function next to the getTreeStats above since they are related.
Or better yet, we can move these tree stat calculating functions to a different file or odspUtils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, but let's do it in separate PR. I prefer to separate mechanical changes (moving things around) and non-mechanical changes - easier to review / go back in time and figure out where regressions occurred.
Take a look at some small comments above and you can merge. Thanks. |
…to SnapshotTelemetry
This PR