-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim exported APIs from odsp-driver and odsp-urlresolver, and strengthen url checks #20488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: driver
Driver related issues
area: odsp-driver
public api change
Changes to a public API
base: main
PRs targeted against main branch
labels
Apr 5, 2024
⯆ @fluid-example/bundle-size-tests: -34 Bytes
Baseline commit: 23652a0 |
jatgarg
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: driver
Driver related issues
area: odsp-driver
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started looking at this due to URL sanitization warnings. I don't suspect these improvements will be sufficient to make those go away completely, but it does make the checks stronger and more correct.
The regexes had a number of bugs and overlooked cases that are now fixed. Added tests covering some of the cases that are now correctly detected.
Stopped exporting the
@internal
items that didn't need to be exported. Converted several functions to takeURL
instead ofstring
for stronger typing and guarantees about part formats (e.g. that "origin" has a valid shape for an origin).