Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim exported APIs from odsp-driver and odsp-urlresolver, and strengthen url checks #20488

Merged
merged 13 commits into from
Apr 5, 2024

Conversation

ChumpChief
Copy link
Contributor

Started looking at this due to URL sanitization warnings. I don't suspect these improvements will be sufficient to make those go away completely, but it does make the checks stronger and more correct.

The regexes had a number of bugs and overlooked cases that are now fixed. Added tests covering some of the cases that are now correctly detected.

Stopped exporting the @internal items that didn't need to be exported. Converted several functions to take URL instead of string for stronger typing and guarantees about part formats (e.g. that "origin" has a valid shape for an origin).

@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver public api change Changes to a public API base: main PRs targeted against main branch labels Apr 5, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Apr 5, 2024

@fluid-example/bundle-size-tests: -34 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 452.49 KB 452.49 KB No change
azureClient.js 545.05 KB 545.05 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 255.4 KB 255.4 KB No change
fluidFramework.js 344.57 KB 344.57 KB No change
loader.js 129.36 KB 129.36 KB No change
map.js 41.35 KB 41.35 KB No change
matrix.js 143.61 KB 143.61 KB No change
odspClient.js 513.29 KB 513.28 KB -15 Bytes
odspDriver.js 97.3 KB 97.29 KB -4 Bytes
odspPrefetchSnapshot.js 41.86 KB 41.86 KB No change
sharedString.js 161.38 KB 161.38 KB No change
sharedTree.js 334.67 KB 334.67 KB No change
Total Size 3.14 MB 3.14 MB -34 Bytes

Baseline commit: 23652a0

Generated by 🚫 dangerJS against ded4142

@ChumpChief ChumpChief merged commit 598c73e into microsoft:main Apr 5, 2024
31 checks passed
@ChumpChief ChumpChief deleted the OdspUrl branch April 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants