Allow more cases in Tree.is

[CraigMacomber]

Description

This makes 3 changes to Tree.is:

1. calling Tree.is(node, SchemaNotUsedInTreeSchema) is no longer an error. This undocumented edge case could have been problematic, and is inconsistent since it would not fire if node was not a TreeNode.
2. Tree.is now takes in ImplicitAllowedTypes, making cases like Tree.is(x, [schema.number, schema.string]) valid. THis is more performant and more concise then doing two separate checks and ORing them together. This also allows checking a node against an ImplicitAllowedTypes pulled from a FieldSchema which could be handy for some generic code.
3. The implementation of Tree.schema and Tree.is have been rewritten to not rely on flex-schema as much, and fast path non-TreeNode inputs. This should make it more maintainable and more performant.

Interestingly #2 above is the only case that couldn't be covered by instanceof (assuming TypeScript 5.3): we could make instanceof do all narrowing currently done with Tree.is, except for this new case. The presence of this case thus seems to motivate keeping Tree.is if for no reason other than it can support this additional pattern which instancof cannot.

Reviewer Guidance

The review process is outlined on this wiki page.

This is a public API change, and thus needs extra review on the API and how it will impact customers.

[msfluid-bot]

⯅ @fluid-example/bundle-size-tests: +182 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	455.86 KB	455.86 KB	■ No change
azureClient.js	552.43 KB	552.43 KB	■ No change
connectionState.js	680 Bytes	680 Bytes	■ No change
containerRuntime.js	258.9 KB	258.9 KB	■ No change
fluidFramework.js	358 KB	358.09 KB	⯅ +91 Bytes
loader.js	133.16 KB	133.16 KB	■ No change
map.js	41.4 KB	41.4 KB	■ No change
matrix.js	143.64 KB	143.64 KB	■ No change
odspClient.js	520.77 KB	520.77 KB	■ No change
odspDriver.js	97.1 KB	97.1 KB	■ No change
odspPrefetchSnapshot.js	41.98 KB	41.98 KB	■ No change
sharedString.js	161.32 KB	161.32 KB	■ No change
sharedTree.js	357.99 KB	358.08 KB	⯅ +91 Bytes
Total Size	3.2 MB	3.2 MB	⯅ +182 Bytes

---

Baseline commit: 5a15835

Generated by 🚫 dangerJS against ffabda2

[noencke]

Do you want to use normalizeAllowedTypes here to avoid manually handling the array and lazies?

[CraigMacomber]

I started with that approach, but it incurs a lot more overhead in both the single item case and the array case. This avoids allocating the set, gets an early return on a match, avoids boxing single items into an array, avoids a bunch of calls, and extra loop etc. The code for this approach is only slightly larger.

Normalize is mainly used in places where we can cache the result and reuse it, which is not the case here (unless we wend with a different API, and returned a node filter predicate).

[noencke]

Got it, sounds good. I wonder if we could get the benefits of the early return and no Set() allocation by using a generator that returns an iterator of the normalized schema. Something to try, later, if we find ourselves doing this same kind of thing in multiple places.