fix(client-presence): update connectivity checks #22580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking runtime.clientId only determines if ever connected. runtime.connected reveals current state.
github-actions
bot
added
area: framework
kashms
reviewed
Sep 20, 2024
| @@ -178,7 +178,7 @@ export class PresenceDatastoreManagerImpl implements PresenceDatastoreManager { | |||
| forceBroadcast: boolean, | |||
| ): void => { | |||
| // Check for connectivity before sending updates. | |||
| if (this.runtime.clientId === undefined) { | |||
| if (!this.runtime.connected) { | |||
There was a problem hiding this comment.
Should we check for both? Or is the runtime.connected check sufficient?
There was a problem hiding this comment.
Just connected is sufficient here. Once ever connected, clientId will be defined henceforth. (Which is how we got the bug.)
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 2f7a9d0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking runtime.clientId only determines if ever connected. runtime.connected reveals current state.