Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client-presence): multiple getStates calls using overlapping schema #22581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(client-presence): multiple getStates calls using overlapping schema #22581

wants to merge 1 commit into from

Conversation

jason-ha
Copy link
Contributor

Check for presence of requested state:

  • if found, check that instance type is minimally compatible (same manager class)
  • if not, add state.

@jason-ha
fix(client-presence): multiple getStates calls using overlapping sc…
5fabfd0 
…hema

Check for presence of requested state:
- if found, check that instance type is minimally compatible (same manager class)
- if not, add state.
@github-actions github-actions bot added base: main PRs targeted against main branch area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct labels Sep 20, 2024
@msfluid-bot
Copy link
Collaborator

⯅ @fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.44 KB 460.47 KB ⯅ +35 Bytes
azureClient.js 559.03 KB 559.08 KB ⯅ +49 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 261.68 KB 261.69 KB ⯅ +14 Bytes
fluidFramework.js 403.45 KB 403.47 KB ⯅ +14 Bytes
loader.js 134.17 KB 134.19 KB ⯅ +14 Bytes
map.js 42.43 KB 42.44 KB ⯅ +7 Bytes
matrix.js 145.87 KB 145.88 KB ⯅ +7 Bytes
odspClient.js 526.18 KB 526.23 KB ⯅ +49 Bytes
odspDriver.js 97.8 KB 97.82 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.76 KB 42.78 KB ⯅ +14 Bytes
sharedString.js 162.84 KB 162.84 KB ⯅ +7 Bytes
sharedTree.js 393.92 KB 393.92 KB ⯅ +7 Bytes
Total Size 3.3 MB 3.3 MB ⯅ +245 Bytes

Baseline commit: 2f7a9d0

Generated by 🚫 dangerJS against 5fabfd0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashms kashms Awaiting requested review from kashms

@sashasimic sashasimic Awaiting requested review from sashasimic

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-ha @msfluid-bot