Skip to content

Commit

Permalink
Merge pull request #3421 from NikCharlebois/Fixes-#3390
Browse files Browse the repository at this point in the history
Fixes #3390
  • Loading branch information
NikCharlebois committed Jun 27, 2023
2 parents 0cf4f3d + 8529f28 commit 98341bf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
13 changes: 8 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@

# UNRELEASED

* AADApplication
* Updated the Set and Test function to ignore the AppId parameter.
FIXES [#3390](https://github.com/microsoft/Microsoft365DSC/issues/3390)
* AADAuthenticationMethodPolicyAuthenticator
* Deprecated the NumberMatchingRequiredState Feature Setting.
FIXES [#3406](https://github.com/microsoft/Microsoft365DSC/issues/3406)
* AADServicePrincipal
* Updated the Set and Test function to ignore the AppId parameter.
FIXES [#3390](https://github.com/microsoft/Microsoft365DSC/issues/3390)
* EXOAvailabilityConfig
* Fixes an error where an error was thrown when the OrgWideAccount wasn't set.
FIXES [#3402](https://github.com/microsoft/Microsoft365DSC/issues/3402)
Expand All @@ -15,13 +21,10 @@
* Added required application permissions to support [Application Based Authentication](https://learn.microsoft.com/en-us/microsoftteams/teams-powershell-application-authentication)
* MISC
* Added API to the Organization.Read.All permission in the Get-M365DSCCompiledPermisisonList cmdlet
* Fixed Update-M365DSCAzureAdApplication where an error was thrown when multiple permissions were specified
for the same API.
* DEPENDENCIES
* Updated ReverseDSC to version 2.0.0.16.
* MISC
* Fixes an issue with Update-M365DSCAzureAdApplication where it was throwing an error complaining about duplicate keys.
FIXES #3417
* DEPENDENCIES
* Updated ReverseDSC to version 2.0.0.16.

# 1.23.621.1

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ function Set-TargetResource
$currentParameters.Remove('Ensure') | Out-Null
$currentParameters.Remove('ObjectID') | Out-Null
$currentParameters.Remove('ApplicationSecret') | Out-Null
$currentParameters.Remove('AppId') | Out-Null

# ServicePrincipal should exist but it doesn't
if ($Ensure -eq 'Present' -and $currentAADServicePrincipal.Ensure -eq 'Absent')
Expand Down Expand Up @@ -444,6 +445,7 @@ function Test-TargetResource
$ValuesToCheck.Remove('CertificateThumbprint') | Out-Null
$ValuesToCheck.Remove('ManagedIdentity') | Out-Null
$ValuesToCheck.Remove('TenantId') | Out-Null
$ValuesToCheck.Remove('AppId') | Out-Null

$TestResult = Test-M365DSCParameterState -CurrentValues $CurrentValues `
-Source $($MyInvocation.MyCommand.Source) `
Expand Down

0 comments on commit 98341bf

Please sign in to comment.