Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intune Firewall Policy for Windows 10 #5056

Open
wants to merge 5 commits into
base: Dev
Choose a base branch
from

Conversation

FabienTschanz
Copy link
Contributor

@FabienTschanz FabienTschanz commented Sep 17, 2024

Pull Request (PR) description

This PR adds support for the Intune resource IntuneFirewallPolicyWindows10. This is the first in a series of resources for the Firewall blade in the Endpoint security section of Intune.

Additionally, it updates the resource generator and M365DSCDRGUtil module for more complex property handling, including properties that share the same name but are under separate instance templates (which has not happened before). To manage that and still generate unique names, it uses recursive traversing of the OffsetUri, which indicates how deep the current property is in the settings tree.

This Pull Request (PR) fixes the following issues

@ricmestre
Copy link
Contributor

Works without issues, I tried to create a couple of policies based off of some I already had created on another production tenant, made some changes to them and finally removed them.

Since you also changed M365DSCDRGUtil I'll run my whole integration pipeline to ensure it doesn't impact anything else, but that takes a couple of hours, I'll let you know the result.

@FabienTschanz
Copy link
Contributor Author

FabienTschanz commented Sep 17, 2024

Thanks a lot @ricmestre. The biggest concern I have is backwards compatibility, so that was my main focus with the changes to the M365DSCDRGUtil. Since the updated unit tests of the settings catalog policies all have a quite good settings coverage and types, I don't necessarily expect any issues, but I can't be certain.

Developing for something new while retaining backwards compatibility without breaking anything is very hard... Especially if the settings catalog keeps getting more and more complex. I'm absolutely no fan of it, but that's life.

Edit: Almost everything in the IntuneFirewallPolicyWindows10 resource was auto-generated by the resource generator. I do think we can make quick progress on the new resources 😄

@ricmestre
Copy link
Contributor

Settings catalog policies are always a pain in the rear, for me specially the main one IntuneSettingCatalogCustomPolicyWindows10 with "infinite" recursive nested levels...

Anyway, all other policies I have tests for still work as expected so it's good to go for me.

@FabienTschanz
Copy link
Contributor Author

@NikCharlebois Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants