Represent nullable references within anyOf correctly #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millicentachieng
requested review from
xuzhg,
irvinesunday,
darrelmiller,
peombwa,
zengin and
baywet
as code owners
millicentachieng
commented
Jul 6, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
baywet
reviewed
Jul 7, 2022
There was a problem hiding this comment.
holding until we get an answer to this comment #190 (comment)
millicentachieng
changed the title
|
alright, after chatting with Darrel on the original issue, it looks like this implementation is doing what's required for now. The only thing left is the comment you had added to avoid inserting unnecessary anyOf nodes when nullable is false in the case of v3. |
baywet
previously approved these changes
Jul 7, 2022
irvinesunday
previously approved these changes
Jul 8, 2022
millicentachieng
dismissed stale reviews from irvinesunday and baywet
via
3ec6bfd
millicentachieng
force-pushed
the
fix/nullable-references
branch
from
c8d4e3a
to
3ec6bfd
Compare
baywet
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190