Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $ref with $id serialization #1851

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Fix $ref with $id serialization #1851

merged 6 commits into from
Oct 2, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1850

@MaggieKimani1 MaggieKimani1 linked an issue Oct 2, 2024 that may be closed by this pull request
Writing $ref values that have a $Id as a value are incorrectly prepending #/components/schema/ #1850
Closed
MaggieKimani1 and others added 2 commits October 2, 2024 17:46
@MaggieKimani1 @darrelmiller
Update src/Microsoft.OpenApi/Models/OpenApiReference.cs
2a95547 
Co-authored-by: Darrel <darrmi@microsoft.com>
@MaggieKimani1 @darrelmiller
Update src/Microsoft.OpenApi/Models/OpenApiReference.cs
66fb599 
Co-authored-by: Darrel <darrmi@microsoft.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MaggieKimani1 MaggieKimani1 merged commit ed5c771 into release/2.0.0 Oct 2, 2024
9 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-$ref-with-$id-serialization branch October 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing $ref values that have a $Id as a value are incorrectly prepending #/components/schema/
2 participants
@MaggieKimani1 @darrelmiller