Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #29

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Refactor tests #29

merged 13 commits into from
Oct 10, 2023

Conversation

peombwa
Copy link
Contributor

@peombwa peombwa commented Oct 2, 2023 •
edited
Loading

Fixes #28 and fixes #32. This PR factors test by:

  • Moves tests folder to root.
  • Adds missing VerificationTokens to OpenAI manifest auth types (OAuth & service level auth)
  • Adds additional tests for OpenAI types.
  • Adds validation for the OpenAI Plugin manifest.

@peombwa peombwa marked this pull request as ready for review October 3, 2023 22:48
@baywet
Copy link
Member

baywet commented Oct 3, 2023

@peombwa Sonarcloud came up with a bunch of code smells with this refactoring. Would you mind addressing them before I review the PR?

@peombwa
Copy link
Contributor Author

peombwa commented Oct 3, 2023

@baywet, please review when you get time. I've fixed the code smells.

baywet
baywet requested changes Oct 5, 2023
View reviewed changes
.github/workflows/sonarcloud.yml Show resolved Hide resolved
src/lib/OpenAI/Auth/BaseManifestAuth.cs Outdated Show resolved Hide resolved
src/lib/OpenAI/Auth/BaseManifestAuth.cs Outdated Show resolved Hide resolved
src/lib/OpenAI/Auth/BaseManifestAuth.cs Outdated Show resolved Hide resolved
src/lib/OpenAI/Auth/ManifestNoAuth.cs Outdated Show resolved Hide resolved
src/lib/OpenAI/Auth/ManifestOAuthAuth.cs Outdated Show resolved Hide resolved
src/lib/ParsingHelpers.cs Outdated Show resolved Hide resolved
tests/ApiManifest.Tests/ApiManifest.Tests.csproj Outdated Show resolved Hide resolved
tests/ApiManifest.Tests/OpenAIPluginManifestTests.cs Outdated Show resolved Hide resolved
@peombwa peombwa requested a review from baywet October 10, 2023 03:40
baywet
baywet requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. A couple of thing left

src/lib/Helpers/ValidationHelpers.cs Outdated Show resolved Hide resolved
src/lib/OpenAI/Authentication/ManifestUserHttpAuth.cs Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

baywet
baywet approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@peombwa peombwa merged commit 79fd328 into main Oct 10, 2023
7 checks passed
@peombwa peombwa deleted the po/refactorTests branch October 10, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OpenAI Plugin Manifest Validation Refactor tests
2 participants
@peombwa @baywet