Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more rule error output in CI #317

Merged
merged 4 commits into from
Feb 20, 2022

Conversation

ArmaanMcleod
Copy link
Contributor

PR Summary

Fixed #308.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@ArmaanMcleod ArmaanMcleod requested a review from a team as a code owner February 19, 2022 10:23
@ArmaanMcleod ArmaanMcleod changed the title Expose rule exception Expose more rule error output in CI Feb 19, 2022
@ArmaanMcleod
Copy link
Contributor Author

ArmaanMcleod commented Feb 19, 2022

@BernieWhite I can probably add these changes to the V2 task version once #313 is merged. I'll remove these from V0/V1 versions as I was updating these versions while testing.

@BernieWhite
Copy link
Member

@ArmaanMcleod Yes sounds good.

Copy link
Member

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod Implementation looks fine if we just move these to V2.

Copy link
Member

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod Nice work! All good to merge.

@ArmaanMcleod ArmaanMcleod merged commit 38b3093 into microsoft:main Feb 20, 2022
@ArmaanMcleod ArmaanMcleod deleted the expose-rule-exception branch February 20, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more rule error output in CI
2 participants