Skip to content

Commit

Permalink
More descriptive test names
Browse files Browse the repository at this point in the history
  • Loading branch information
joseartrivera committed Dec 11, 2018
1 parent fdc32ee commit edfa795
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Tests/GitHubLabels.tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -287,13 +287,13 @@ try
'enhancement', 'up for grabs', 'question', 'discussion', 'wontfix', 'in progress', 'ready')
$addedLabels = @(Add-GitHubIssueLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number -LabelName $labelsToAdd)

It 'Should return the expected number of labels' {
It 'Should return the number of labels that were just added' {
$addedLabels.Count | Should be $defaultLabels.Count
}

$labelIssues = Get-GitHubLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number

It 'Should have added the expected number of labels' {
It 'Should return the number of labels that were just added from querying the issue again' {
$labelIssues.Count | Should be $defaultLabels.Count
}
}
Expand All @@ -317,7 +317,7 @@ try
Remove-GitHubIssueLabel -OwnerName $ownerName -RepositoryName $repositoryName -Name "bug" -Issue $issue.number
$labelIssues = Get-GitHubLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number

It 'Should have added the expected number of labels' {
It 'Should have removed three labels from the issue' {
$labelIssues.Count | Should be ($defaultLabels.Count - 3)
}
}
Expand All @@ -326,7 +326,7 @@ try
Remove-GitHubIssueLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number
$labelIssues = Get-GitHubLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number

It 'Should have added the expected number of labels' {
It 'Should have removed all labels from the issue' {
$labelIssues.Count | Should be 0
}
}
Expand All @@ -348,13 +348,13 @@ try

$addedLabels = @(Set-GitHubIssueLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number -LabelName $labelsToAdd)

It 'Should return the expected number of labels' {
It 'Should should returned the issue with 14 labels' {
$addedLabels.Count | Should be $labelsToAdd.Count
}

$labelIssues = Get-GitHubLabel -OwnerName $ownerName -RepositoryName $repositoryName -Issue $issue.number

It 'Should have added the expected number of labels' {
It 'Should should have 14 labels after querying the issue' {

This comment has been minimized.

Copy link
@danbelcher-MSFT

danbelcher-MSFT Dec 11, 2018

nit: incorrect sentence

$labelIssues.Count | Should be $defaultLabels.Count
}

Expand Down

0 comments on commit edfa795

Please sign in to comment.