Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comma as decimal delimiter in the calculator #3367

Closed
DavidG2604 opened this issue May 20, 2020 · 13 comments
Closed

Support comma as decimal delimiter in the calculator #3367

DavidG2604 opened this issue May 20, 2020 · 13 comments
Labels
Area-Localization issues regarding to Localization the application Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@DavidG2604
Copy link

I'm using version 0.18 of PowerToys and I'm talking about the integrated calculator in PowerToys Run here:

In the german area, we use the comma and not the period as a decimal-delimiter. The current version of the calculator in PowerToys Run only accepts periods as decimal-delimiter. Please add support for the comma and auto-detect Windows settings for regional format, as the Windows regional format has a setting for this.

Thank you!

@crutkas crutkas added this to the v1.0 Release milestone May 20, 2020
@crutkas crutkas added Area-Localization issues regarding to Localization the application Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels May 20, 2020
@crutkas
Copy link
Member

crutkas commented May 20, 2020

Great catch!

@crutkas crutkas added the Issue-Bug Something isn't working label May 20, 2020
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented May 23, 2020

Even though I hate the fact that these differences exist in the first place, I agree that it should be easy to implement by checking the Regional settings in Windows.
Edit: this method should be default.

@crutkas
Copy link
Member

crutkas commented May 23, 2020

Agreed and totally fair feedback.

@iamahumanbeing
Copy link

Please also support the thousands separator (for example 12,345 instead of just 12345) This will help when you copy and paste from other content such as web sites or Excel spreadsheets as numbers are often formatted this way. Of course, the thousands separator characters should be determined using the locale settings in Windows (so , for countries like US and . for some European countries)

@crutkas
Copy link
Member

crutkas commented May 26, 2020

Yup, marking it a .20 work item. (2 releases from now)

@arsunt95
Copy link

arsunt95 commented Oct 7, 2020

Please develop this :o)

The total displayed is crazy :
image

8 . 43*2 = 16 , 86

it does not matter but with the clipboard, it's difficult to work.

@crutkas
Copy link
Member

crutkas commented Oct 9, 2020

The output should be your localized versions for numbers.

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Oct 21, 2020

The output should be your localized versions for numbers.

The output is localized, as you say, but the input doesn't seem to work in 0.23.2 yet.
image

Also, is #2265 still on the radar?

@DervishD
Copy link

In last version when I'm writing this, 0.25.0, the output of the calculation is correctly localized, but the input is not, you're forced to use the C locale decimal delimiter (a dot)

@crutkas
Copy link
Member

crutkas commented Oct 31, 2020

The problem is the parser. That itself isn't and we are using a 3rd party library for that. The calculator team is working on doing a parser as well that is my hope we can leverage.

@leosdad
Copy link

leosdad commented Dec 8, 2020

Even though I hate the fact that these differences exist in the first place

Don't. The world is the way it is.

@crutkas
Copy link
Member

crutkas commented Dec 8, 2020

moving this to #2265. Once we get the calc engine, localization support will be part of the requirement.

@crutkas crutkas closed this as completed Dec 8, 2020
@crutkas crutkas added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Dec 8, 2020
@enricogior enricogior changed the title Support comma as decimal-delimiter in the calculator Support comma as decimal delimiter in the calculator Jan 14, 2021
@enricogior
Copy link
Contributor

enricogior commented Jan 25, 2021

This is now fixed. The fix will be available in 0.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization issues regarding to Localization the application Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

No branches or pull requests

9 participants