Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility for assigning keyboard shortcut in Settings page #3445

Closed
asklar opened this issue May 21, 2020 · 1 comment
Closed

Improve accessibility for assigning keyboard shortcut in Settings page #3445

asklar opened this issue May 21, 2020 · 1 comment
Labels
Area-Accessibility Issues related to accessibility Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Product-Settings The standalone PowerToys Settings application
Milestone
Stability Release

Comments

@asklar
Copy link
Member

asklar commented May 21, 2020

open powertoys, go to Run page.
Several problems:
Once you put focus in the "shortcut key" textbox, it will capture all input.
This means this page is not keyboard accessible (can't tab around the page)
focus can never move from that textbox
can't invoke window menu with ctrl+space because then the shortcut becomes ctrl+space

A better design would be to show the shortcut in a readonly textbox and have a Change button
@jyuwono jyuwono added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Product-Settings The standalone PowerToys Settings application labels May 21, 2020
@jyuwono jyuwono changed the title Powertoys run dialog has immovable focus on shortcut field Powertoys Run Settings dialog has immovable focus on shortcut field May 21, 2020
@jyuwono jyuwono added Area-Accessibility Issues related to accessibility Idea-Enhancement New feature or request on an existing product labels Jun 3, 2020
@jyuwono jyuwono changed the title Powertoys Run Settings dialog has immovable focus on shortcut field Improve accessibility for assigning keyboard shortcut in Settings page Jun 3, 2020
@jyuwono jyuwono added this to the v1.0 Release milestone Jun 3, 2020
@jyuwono jyuwono mentioned this issue Jun 12, 2020
Closed
@crutkas
Copy link
Member

crutkas commented Dec 10, 2020

this is fixed now from I believe 0.25 on.

@crutkas crutkas closed this as completed Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Product-Settings The standalone PowerToys Settings application
Projects
None yet
Milestone
Stability Release
Development

No branches or pull requests
3 participants
@crutkas @jyuwono @asklar