PT Run Shortcut Key change does not save if window is closed before focus is lost

[Sophist-UK]

Environment

Microsoft Windows [Version 10.0.18363.836]
PowerToys version: v0.18.2
PowerToys module for which you are reporting the bug (if applicable): Run

Steps to reproduce

Open Settings, select PT Run, change the Shortcut Key without clicking elsewhere and losing focus, close settings, reopen settings, select PT Run, see if change has persisted

Expected behavior

Change of Shortcut Key persists

Actual behavior

Change of Shortcut Key doesn't persist.

NOTE: Default Shortcut Key of Alt-Space is IMO not a good one as this is the shortcut key for the current active window Max/Min/Restore/Close popup.

[jyuwono]

hi @Sophist-UK, what did you change the shortcut to?

[Sophist-UK]

Ctrl-\

[androidSwDev099]

Ctrl-\

After you change it to Ctrl-, try clicking somewhere outside the PT Run Open PowerToys Run box, but still within the PowerToys Settings window so you can see it's Ctrl-\ before closing the window.

[Sophist-UK]

@androidSwDev099 Yes - you seem to be correct. The new value is only being saved when the control loses focus.

Not great UI design when that is not obvious.

[androidSwDev099]

Now they can reproduce and fix it with a confirmation ok button.

[jyuwono]

@Sophist-UK is the issue resolved now? For improving UI, it is being tracked in #3445

[Sophist-UK]

Or save the value whenever it changes not just when the control loses focus.

If there are other hotkey settings fields, this may be an issue common to all of them.

[crutkas]

i think #3445 is a better tracking issue.