Quickaccess systemtray launcher #22408

niels9001 · 2022-12-01T18:47:53Z

Summary of the Pull Request

This PR introduces a new way of launching various PowerToys modules by clicking on the icon in the system tray.

Features:

Layout showing activated modules that can be launched using the launcher.
The tooltip of each module shows the activation shortcut.
Settings and docs can be opened.
Modules that are disabled will not be shown.
If there's an update available, this will be shown for awareness.

Things to do:

Localization & a11y
Telemetry?

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Wire up colorpicker and pt run

…t/PowerToys into feature/sytrayflyoutpoc

Jay-o-Way · 2022-12-01T19:09:07Z

Do we want to show modules that are disabled as disabled icons?

Actually, my personal thought is comparing this with the Action Center. Here you can also find things that are on/off, and this is the place to turn it on. So, for me, this would be a no-brainer :)

That does mean that there would be like 18 modules here in the window...

Would also be nice if this could replace the full current PT icon menu ("report bug" etc.)

niels9001 · 2022-12-01T21:05:19Z

Do we want to show modules that are disabled as disabled icons?

Actually, my personal thought is comparing this with the Action Center. Here you can also find things that are on/off, and this is the place to turn it on. So, for me, this would be a no-brainer :)

That does mean that there would be like 18 modules here in the window...

Would also be nice if this could replace the full current PT icon menu ("report bug" etc.)

That's why I'm not in favor in supporting it 😁: it's meant to be a launcher, that allows launching modules that can only be triggered by a keyboard shortcut. There's little value in turning on/off context-menu modules and replacing Settings?

Quick Actions only support settings that users regularly toggle between - for PT, I could imagine a toggle for KBM and Awake modes?

htcfreek · 2022-12-02T00:57:09Z

@niels9001
Nice work. Does it replaces the tray menu?

Here are some thoughts/ideas:

I think it should be a launcher and information center only.
Some additional features would be nice: Showing the active fz layouts per monitor, controling awake, controling vcm. I think it could be realized that wen we click on the module icon the additional features panel for the module is expanding.
If an update is shown, can the user open the settings by clicking on the update info?
Personally I would replace the document symbol with a help/question symbol.
A third symbol to open the scoobe/oobe page might be useful.

BobSimms · 2022-12-03T19:37:44Z

Support for easy turning on/off would especially be useful for KBM. I use it when my laptop is undocked to make the condensed keyboard’s alternate Fn behavior (PrtSc, Home, Ins) of F9 F10 F11 keys the main behavior for editing convenience, and so that other function keys behave in programs as their usual purpose, like F3 find-next, F5 refresh, etc. When docked I turn it off because the bigger keyboard has separate PrtSc, Home, and Ins keys, leaving F1-F12 normal.

JaykeBird · 2022-12-04T19:14:33Z

I think this idea is amazing and I'd love to see it in whatever form is best.

I think being able to turn on/off all modules from here would be a bit much and overcomplicate it, but options for Awake or KBM could be good. Besides, Settings is just one click away from here. (Although maybe such an option could be added via a context menu when right-clicking a module?)

I also think the file icon for documentation isn't immediately obvious; I'd also agree with using a question mark or help icon would be better.

Either way, I'd love to see this added in!

Aaron-Junker · 2022-12-04T19:33:59Z

My opinion is that like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality.

niels9001 · 2022-12-05T09:33:59Z

My opinion is that like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality.

Fair point - not sure if it'll be a major hurdle, but if so we could adopt the Start Menu grid-like design as it's more inline with app launching.

bzzrak · 2022-12-05T12:55:11Z

What's the point of showing the hosts file editor there? That can be launched with just the exe file (at program files\powertoys\modules). As I see it, this is much better suited to launching things that are otherwise accessible only with the keyboard, like Run, the colour picker or the OCR recogniser.

Besides I don't think there's a lot of people that need to edit the hosts file so often that they need a "quick access" thingy for it. If they do, as I said, they can just make a shortcut to its exe file.

Other than that I think it looks cool :D

Jay-o-Way · 2022-12-31T15:46:27Z

My opinion is that like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality.

I think we need a Discussion to poll ideas from users. I feel there are different interpretations from us already, so we should ask the users.

jaimecbernardo · 2023-01-26T23:47:21Z

I've removed VCM from the list of apps. It's legacy and it's only controllable when running as admin. Best leave it out.

… only if there is no page opened

jaimecbernardo · 2023-01-30T16:36:39Z

Currently trying to figure out this flicker:

It seems to be happening on mouse over and only happens when we're running without debugger attached (the presence of a debugger makes it so that the flicker doesn't occur)
It seems somehow related to the FlyoutMenuButton or the BitmapIcon rendered for it, since that's what's flickering.

stefansjfw · 2023-01-30T17:01:42Z

src/settings-ui/Settings.UI/OOBE/ViewModel/OobePowerToysModule.cs

@@ -41,7 +41,7 @@ public void LogOpeningSettingsEvent()

        public void LogRunningModuleEvent()
        {
-            PowerToysTelemetry.Log.WriteEvent(new OobeModuleRunEvent() { ModuleName = this.ModuleName });
+            PowerToysTelemetry.Log.WriteEvent(new TrayFlyoutModuleRunEvent() { ModuleName = this.ModuleName });


this change looks wrong

You're very right! Just fixed it. I used that event as a basis and then changed the wrong one. 🤦 It should be good now.

jaimecbernardo · 2023-01-30T17:06:46Z

Changed the BitmapIcons to Images with BitmapImages, as those don't have the "flickering" behavior.

jaimecbernardo

LGTM! Great work! ;)
And thank you for the contribution!

stefansjfw

Great work! I like the flyout very much! I gave it a test, everything works well.

stefansjfw · 2023-01-30T17:55:46Z

src/settings-ui/Settings.UI/Views/ShellPage.xaml.cs

+        }
+
+        /// <summary>
+        /// Set flyout opening callback function


comment is wrong

Fixed it. Thanks for the review!

niels9001 and others added 17 commits September 1, 2022 14:54

Init

c59e0d5

Fix running settings

baf9774

UI design

1830a97

Left click trigger

f62d01e

Wire up colorpicker and pt run

Wire up others

a282848

Update FlyoutWindow.xaml.cs

35c83b0

Removed comments

3f1a304

Update FlyoutWindow.xaml

1231ec7

Merge branch 'main' into feature/sytrayflyoutpoc

46c4c53

More work

b1b5e05

Open Settings page

72aa1b5

Merge branch 'main' into feature/sytrayflyoutpoc

d73b837

Merge branch 'main' into feature/sytrayflyoutpoc

6de8f58

Merge branch 'main' into feature/sytrayflyoutpoc

1f97768

Migrate spelling-0.0.21 changes from main

8fee8c1

More UI work

6389d0b

Merge branch 'feature/sytrayflyoutpoc' of https://github.com/microsof…

544ce00

…t/PowerToys into feature/sytrayflyoutpoc

This comment has been minimized.

Sign in to view

lin-ycv mentioned this pull request Dec 6, 2022

Single shortcut to access all Power Toys #22514

Closed

mchowdhury mentioned this pull request Dec 12, 2022

Change Awake icon in the tray depending on the current state #11996

Closed

niels9001 mentioned this pull request Jan 6, 2023

Quick access to some of the shortcuts also with a mouse, or with touch #21994

Closed

jaimecbernardo added 2 commits January 26, 2023 23:44

fix spellcheck

28e455d

Remove VCM from the list

c56885a

donlaci and others added 9 commits January 27, 2023 08:01

[General] flyout: fix settings window opening. Switch to general page…

fad9252

… only if there is no page opened

[general] flyout: add launching hosts app

7182f7b

Fix CI build

a6f86e7

adding check on elevation when launching hosts

c59683c

Use localization strings that already exist

d200852

Remove dll not present in arm64 build

f390b86

Adding GPO policy check for the launcher page items

1341def

fix hosts launching

0a8d74e

Add telemetry

3be3239

This comment has been minimized.

Sign in to view

jaimecbernardo added 2 commits January 27, 2023 15:17

Also hide from all apps list when gpo is force enabling

24f10b8

fix spellchecker

0625f25

This comment has been minimized.

Sign in to view

jaimecbernardo added 2 commits January 30, 2023 11:36

Improve focus issues

3721737

Merge branch 'main' into feature/sytrayflyoutpoc

6f3f346

stefansjfw reviewed Jan 30, 2023

View reviewed changes

jaimecbernardo added 2 commits January 30, 2023 17:03

Fix flickering Bitmap Icons

402a203

Fix telemetry error

f9dde03

jaimecbernardo approved these changes Jan 30, 2023

View reviewed changes

Fix telemetry call

1f0fb52

stefansjfw approved these changes Jan 30, 2023

View reviewed changes

Fix wrong comment

0fe619f

jaimecbernardo merged commit c1c14b4 into main Jan 30, 2023

crutkas deleted the feature/sytrayflyoutpoc branch January 31, 2023 03:56

niels9001 mentioned this pull request Mar 21, 2023

New/Re-do Flyout window: Win 11 Start style, hotkeys, on/off #24880

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quickaccess systemtray launcher #22408

Quickaccess systemtray launcher #22408

niels9001 commented Dec 1, 2022 •

edited

Loading

This comment has been minimized.

Jay-o-Way commented Dec 1, 2022 •

edited

Loading

niels9001 commented Dec 1, 2022 •

edited

Loading

htcfreek commented Dec 2, 2022 •

edited

Loading

BobSimms commented Dec 3, 2022

JaykeBird commented Dec 4, 2022

Aaron-Junker commented Dec 4, 2022

niels9001 commented Dec 5, 2022

bzzrak commented Dec 5, 2022 •

edited

Loading

Jay-o-Way commented Dec 31, 2022

jaimecbernardo commented Jan 26, 2023

This comment has been minimized.

This comment has been minimized.

jaimecbernardo commented Jan 30, 2023

stefansjfw Jan 30, 2023

jaimecbernardo Jan 30, 2023

jaimecbernardo commented Jan 30, 2023

jaimecbernardo left a comment

stefansjfw left a comment

stefansjfw Jan 30, 2023

jaimecbernardo Jan 30, 2023

Quickaccess systemtray launcher #22408

Quickaccess systemtray launcher #22408

Conversation

niels9001 commented Dec 1, 2022 • edited Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

Jay-o-Way commented Dec 1, 2022 • edited Loading

niels9001 commented Dec 1, 2022 • edited Loading

htcfreek commented Dec 2, 2022 • edited Loading

BobSimms commented Dec 3, 2022

JaykeBird commented Dec 4, 2022

Aaron-Junker commented Dec 4, 2022

niels9001 commented Dec 5, 2022

bzzrak commented Dec 5, 2022 • edited Loading

Jay-o-Way commented Dec 31, 2022

jaimecbernardo commented Jan 26, 2023

This comment has been minimized.

This comment has been minimized.

jaimecbernardo commented Jan 30, 2023

stefansjfw Jan 30, 2023

Choose a reason for hiding this comment

jaimecbernardo Jan 30, 2023

Choose a reason for hiding this comment

jaimecbernardo commented Jan 30, 2023

jaimecbernardo left a comment

Choose a reason for hiding this comment

stefansjfw left a comment

Choose a reason for hiding this comment

stefansjfw Jan 30, 2023

Choose a reason for hiding this comment

jaimecbernardo Jan 30, 2023

Choose a reason for hiding this comment

niels9001 commented Dec 1, 2022 •

edited

Loading

Jay-o-Way commented Dec 1, 2022 •

edited

Loading

niels9001 commented Dec 1, 2022 •

edited

Loading

htcfreek commented Dec 2, 2022 •

edited

Loading

bzzrak commented Dec 5, 2022 •

edited

Loading