[Mouse Jump] - reduce winforms dependency, new thumbnail size settings, add shortcut keys - Ready For Review

[mikeclayton]

Summary of the Pull Request

Makes a few improvements to Mouse Jump:

• [Mouse Jump] - reduce dependency on WinForms utility classes #25482
• [Mouse Jump] - improve popup responsiveness #25484
• Custom size window for mouse jump (larger / smaller) #24564
• Provide shortcut keys for the previous screen or the next screen for the mouse jump function #25069

There's a summary below for each issue, and more details are available on each issue page...

1 - #25482 - reduce WinForms dependency

Added more Win32 API calls to remove the need for using the following built-in WinForms classes. This will make it easier to transition to a new presentation framework (WPF / WinUI3) at a later date if desired

• System.Windows.Forms.Cursor
• System.Windows.Forms.Screen
• System.Windows.Forms.SystemInformation

This is the first 6 commits in this PR, down to (and including) d0489ae

2 - #25484 - improve popup responsiveness

If the form takes longer than 250ms to initialise it displays the preview with black rectangles and now renders screens incrementally one at a time to make it more responsive. (Behavior in 0.69.1 is to show the black rectangles but only refresh the thumbnail image once all remaining screenshots have been taken, so still feels a bit sluggish compared to this incremental approach)

FancyMouse.-.progressive.preview.v2.-.normal.mp4

3 - #24564 - customizable preview size

Added a Mouse Utils setting to specify the size of the preview image - default value is 1600 x 1200.

4 - #25069 - shortcuts for screen navigation

When the preview screen is visible the following keys will now move the cursor to the center of the appropriate screen.

Key	Action
Key 1-9 NumPad 1-9	Move to center of numbered screen
"P"	Move to center of primary screen (not sure if this needs to be localizable?)
Left Arrow	Move to center of previous screen (wraps around screens 1..N)
Right Arrow	Move to center of next screen (wraps around screens 1..N)
Home	Move to center of first screen
End	Move to center of last screen

Screen numbers and sequence order for first / last / previous / next are per Display Settings

Future work:

• Handle more than 9 screens?
• When the preview image is visible, if a designated key is held down (e.g. ctrl), overlay screen numbers on the individual miniature screenshot images to help identify them (similar to the "Identify" button on the Display Settings dialog, but show the numbers on the preview image rather than as overlays on the actual screens themselves.

PR Checklist

• Closes:
  • [Mouse Jump] - reduce dependency on WinForms utility classes #25482
  • [Mouse Jump] - improve popup responsiveness #25484
  • Custom size window for mouse jump (larger / smaller) #24564
  • Provide shortcut keys for the previous screen or the next screen for the mouse jump function #25069
• Communication: I've discussed this with @crutkas already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
  • "Thumbnail Size" settings strings all localised
• Dev docs: Added/updated
  • no changes
• New binaries: Added on the required places
  • no changes
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx
  • no changes

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

• Automated tests passing locally
• Minimal actions workflow (spelling check) passing for PR
• Full actions workflow (msbuild) passing for PR
• Manual regression-testing scenarios
  • Happy path - clicking the thumbnail image works and cursor moves to the correct location
  • Works on multiple monitors with different dpi scaling settings (e.g. 100% vs 150%)
    • [Mouse Jump] - new feature - #23216 #23566 (comment)
    • [Mouse Jump] - new feature - #23216 #23566 (comment)
  • Handling negative coordinates on non-primary monitors if higher or "lefter" than primary monitor
    • [Mouse Jump] - new feature - #23216 #23566 (comment)
  • Mouse crosshair moves when Mouse Jump moves the cursor (mouse clicks and keyboard shortcuts)
    • Mouse pointer Crosshair & Mouse Jump Issue #24523
    • [MouseJump]Also simulate mouse input event #24527

[mikeclayton]

@jaimecbernardo @htcfreek @crutkas - just a courtesy ping to let you know this PR is ready for review (assuming the build works!)

[htcfreek]

@niels9001
For me the content dialogue feels a bit odd here. Any ideas how we can get this into the settings action content?

[jaimecbernardo]

Hi @mikeclayton ,
Great work! Thank you for the contribution!
I've done some in depth tests, including building an installer, and everything seems to be working great.
Code changes LGTM, too.

For future work, it makes sense to describe the new shortcuts in the Settings, but I don't think this needs to be part of this PR.

[jaimecbernardo]

The change suggested by @htcfreek can be part of another PR as well.

[mikeclayton]

Fab, thanks.

I'll raise some issues for the "future work" suggestions once v70 has been released.