Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Filter for non-processable windows #28956

Merged

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Oct 2, 2023

Summary of the Pull Request

Check the popup windows style in WindowCreated.

PR Checklist

Detailed Description of the Pull Request / Additional comments

0.74:
not-fixed

Fixed:
fixed

Validation Steps Performed

Snap the Godot window, open any menu, and verify it's opened as expected.

@SeraphimaZykova SeraphimaZykova linked an issue Oct 2, 2023 that may be closed by this pull request
@SeraphimaZykova SeraphimaZykova changed the title [FancyZones] Check filtering non-processable windows [FancyZones] Filter for non-processable windows Oct 2, 2023
@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Oct 2, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix!

@jaimecbernardo jaimecbernardo merged commit 11f30f9 into main Oct 2, 2023
10 checks passed
@SeraphimaZykova SeraphimaZykova deleted the seraphima/28914-context-menu-location-is-incorrect branch October 3, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu location is incorrect
2 participants