Theming for powertoys run #4007

dsrivastavv · 2020-06-03T00:25:26Z

Summary of the Pull Request

Added support for light, dark and high contrast themes in PowerToys run

References

https://mahapps.com/docs/themes/thememanager

PR Checklist

Applies to [pt run] theming enabled #3485
CLA signed. If not, go over here and sign the CLA
Tests added/passed

Detailed Description of the Pull Request / Additional comments

Added Theme Manager for PowerToys Run using theming interface for Mahapps
Added dark, light and high contrast theme
Removed themes inherited from Wox

Validation Steps Performed

Manually validated that theme is changed when toggled between dark, light, high contrast 1, high contrast 2, high contrast black and high contrast white modes.

Know Issues

When theme is changed, previously applied theme flashes and then the new theme is applied.
Currently, all high contrast themes only have dummy values.

Dark Theme

High contrastTheme

LightTheme

crutkas · 2020-06-03T01:40:27Z

Think we will need some TLC on high contrast but awesome!

niels9001

Agreed with @crutkas - I think we need to atleast change the hover visual to purple/green.

I realized that Windows provides different contrast themes. Which one do we support? What is part of this PR is I similar to HighContrast White.

dsrivastavv · 2020-06-03T17:51:34Z

@niels9001 I have found a way in which we handle all the four types of contrast separately. I will push the changes and let you know.

dsrivastavv · 2020-06-03T20:15:54Z

installer/PowerToysSetup/Product.wxs

@@ -787,7 +787,7 @@
  <Fragment>
    <ComponentGroup Id="LauncherComponents">
      <Component Id="launcherInstallComponent" Directory="LauncherInstallFolder" Guid="5E688DB4-C522-4268-BA54-ED1CDFFE9DB6">
-        <?foreach File in concrt140_app.dll;ICSharpCode.SharpZipLib.dll;JetBrains.Annotations.dll;Mages.Core.dll;Microsoft.Search.Interop.dll;EntityFramework.SqlServer.dll;EntityFramework.dll;Mono.Cecil.dll;Mono.Cecil.Mdb.dll;Mono.Cecil.Pdb.dll;Mono.Cecil.Rocks.dll;msvcp140_1_app.dll;msvcp140_2_app.dll;msvcp140_app.dll;Newtonsoft.Json.dll;NHotkey.dll;NHotkey.Wpf.dll;NLog.dll;NLog.Extensions.Logging.dll;Pinyin4Net.dll;PowerLauncher.deps.json;PowerLauncher.dll;PowerLauncher.exe;Microsoft.Toolkit.Win32.UI.XamlHost.Managed.dll;Microsoft.Toolkit.Wpf.UI.XamlHost.dll;Microsoft.Xaml.Behaviors.dll;System.Text.Json.dll;sni.dll;System.Data.SQLite.EF6.dll;PowerLauncher.runtimeconfig.json;SQLite.Interop.dll;System.Data.OleDb.dll;System.Data.SqlClient.dll;System.Data.SQLite.dll;vcamp140_app.dll;vccorlib140_app.dll;vcomp140_app.dll;vcruntime140_1_app.dll;vcruntime140_app.dll;WindowsInput.dll;Wox.Core.dll;Wox.dll;Wox.Infrastructure.dll;Wox.Plugin.dll;PowerToysInterop.dll;Telemetry.dll;PowerLauncher.Telemetry.dll;PropertyChanged.dll;Microsoft.Extensions.Configuration.Abstractions.dll;Microsoft.Extensions.Configuration.Binder.dll;Microsoft.Extensions.Configuration.dll;Microsoft.Extensions.DependencyInjection.Abstractions.dll;Microsoft.Extensions.DependencyInjection.dll;Microsoft.Extensions.Logging.Abstractions.dll;Microsoft.Extensions.Logging.dll;Microsoft.Extensions.Options.dll;Microsoft.Extensions.Primitives.dll?>
+        <?foreach File in concrt140_app.dll;ICSharpCode.SharpZipLib.dll;JetBrains.Annotations.dll;Mages.Core.dll;Microsoft.Search.Interop.dll;EntityFramework.SqlServer.dll;EntityFramework.dll;Mono.Cecil.dll;Mono.Cecil.Mdb.dll;Mono.Cecil.Pdb.dll;Mono.Cecil.Rocks.dll;msvcp140_1_app.dll;msvcp140_2_app.dll;msvcp140_app.dll;Newtonsoft.Json.dll;NHotkey.dll;NHotkey.Wpf.dll;NLog.dll;NLog.Extensions.Logging.dll;Pinyin4Net.dll;PowerLauncher.deps.json;PowerLauncher.dll;PowerLauncher.exe;Microsoft.Toolkit.Win32.UI.XamlHost.Managed.dll;Microsoft.Toolkit.Wpf.UI.XamlHost.dll;Microsoft.Xaml.Behaviors.dll;System.Text.Json.dll;sni.dll;System.Data.SQLite.EF6.dll;PowerLauncher.runtimeconfig.json;SQLite.Interop.dll;System.Data.OleDb.dll;System.Data.SqlClient.dll;System.Data.SQLite.dll;vcamp140_app.dll;vccorlib140_app.dll;vcomp140_app.dll;vcruntime140_1_app.dll;vcruntime140_app.dll;WindowsInput.dll;Wox.Core.dll;Wox.dll;Wox.Infrastructure.dll;Wox.Plugin.dll;PowerToysInterop.dll;Telemetry.dll;PowerLauncher.Telemetry.dll;PropertyChanged.dll;Microsoft.Extensions.Configuration.Abstractions.dll;Microsoft.Extensions.Configuration.Binder.dll;Microsoft.Extensions.Configuration.dll;Microsoft.Extensions.DependencyInjection.Abstractions.dll;Microsoft.Extensions.DependencyInjection.dll;Microsoft.Extensions.Logging.Abstractions.dll;Microsoft.Extensions.Logging.dll;Microsoft.Extensions.Options.dll;Microsoft.Extensions.Primitives.dll;ControlzEx.dll;MahApps.Metro.dll?>


I added the following dll's at the end: ControlzEx.dll, MahApps.Metro.dll

niels9001 · 2020-06-03T20:23:26Z

@niels9001 I have found a way in which we handle all the four types of contrast separately. I will push the changes and let you know.

That'd be great! Once that's in I'll make sure to update all the high contrast themes right colors.

dsrivastavv · 2020-06-03T20:44:01Z

@niels9001 I have found a way in which we handle all the four types of contrast separately. I will push the changes and let you know.

That'd be great! Once that's in I'll make sure to update all the high contrast themes right colors.

Sound good! Thanks a lot, Niels 😄

alekhyareddy28

I don't see the accent colors changing in PT Run when I change the windows accent. Is that expected behavior? Personally I would like my accent colors to be the same as that of windows. Doesn't have to be a part of this PR if we choose to go ahead with it.

nit: Can you pls update the reference link in the Summary of this PR to https://mahapps.com/docs/themes/thememanager, it shows a 404 when I click on the present link.

crutkas · 2020-06-05T15:46:08Z

I don't see the accent colors changing in PT Run when I change the windows accent. Is that expected behavior? Personally I would like my accent colors to be the same as that of windows. Doesn't have to be a part of this PR if we choose to go ahead with it.

Let’s log a new bug for that with what accent isn’t correct.

niels9001 · 2020-06-05T15:49:52Z

I think WPF requires you to restart the app for the Accebt brush update. I recall we had something like that in the Fancy Zones editor as well.

AnuthaDev · 2020-06-05T16:04:02Z

For updating accent color, #2988 might help😊

dsrivastavv · 2020-06-05T16:27:18Z

@alekhyareddy28 Updating with accent color wasn't in the scope of this PR. We used controlzex to register a callback for theme change but it doesn't fire a callback on accent changes and only on light/dark base color changes. Also as Niels pointed out, if we use Mahapps accent brushes they would require system to be restarted before the changes can take effect. I will file a bug for accent color so we can track this.

dsrivastavv · 2020-06-05T16:30:06Z

@AnuthaDev Correct me if I am wrong but your changes in #2988 would only be applied on launcher startup and not on accent changes at runtime?

AnuthaDev · 2020-06-05T16:32:00Z

@AnuthaDev Correct me if I am wrong but your changes in #2998 would only be applied on launcher startup and not on accent changes at runtime?

Everytime the visibility of launcher is changed, i.e. whenever you launch it using alt+space

AnuthaDev · 2020-06-05T16:33:53Z

Its a simple solution, whenever the launcher visibility changes, query and set the accentcolor

AnuthaDev · 2020-06-05T16:43:18Z

Something like this would have greatly simplified the code, but afaik its uwp only:

https://docs.microsoft.com/en-us/windows/uwp/data-binding/function-bindings

dsrivastavv · 2020-06-05T16:58:10Z

@AnuthaDev Correct me if I am wrong but your changes in #2998 would only be applied on launcher startup and not on accent changes at runtime?

Everytime the visibility of launcher is changed, i.e. whenever you launch it using alt+spac

Its a simple solution, whenever the launcher visibility changes, query and set the accentcolor

@AnuthaDev I have created an issue for this. Let's move this discussion to #4107.

AnuthaDev · 2020-06-06T09:47:56Z

@somil55 Bro you disabled cleartype with this🙄. Don't change the opacity of colors to change the color value. The alpha channel should always be FF.

dsrivastavv · 2020-06-06T10:12:38Z

@AnuthaDev Please look at #4119 for any color-related settings for this PR.

dsrivastavv added 6 commits June 2, 2020 11:36

Removed Wox Theme Manager

e66ec18

Added Light and dark theme and template for high contrast theme

a376f25

Updated themeManager to remove strings

45c474b

Fixed issue with high contrast theme not being applied

8a3982d

Fixed formatting

10734aa

Merge remote-tracking branch 'upstream/master' into somil55/WPFTheme

2371524

dsrivastavv requested review from niels9001 and a team June 3, 2020 00:25

niels9001 approved these changes Jun 3, 2020

View reviewed changes

dsrivastavv added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jun 3, 2020

dsrivastavv added 2 commits June 3, 2020 12:41

Merge remote-tracking branch 'upstream/master' into somil55/WPFTheme

cf3dee3

Updated MSI to include dll for Mahapps and controlzex

978b0c1

dsrivastavv commented Jun 3, 2020

View reviewed changes

Added support for multiple high contrast themes

b21cec5

alekhyareddy28 reviewed Jun 5, 2020

View reviewed changes

alekhyareddy28 approved these changes Jun 5, 2020

View reviewed changes

dsrivastavv merged commit 6adb47c into microsoft:master Jun 5, 2020

niels9001 mentioned this pull request Jun 5, 2020

[PT Run] Updated themes (dark/light/highcontrast) #4119

Merged

2 tasks

htcfreek mentioned this pull request Jun 6, 2020

[PowerToys Run] Ability to toggle between themes in settings #4034

Closed

dsrivastavv mentioned this pull request Sep 28, 2020

Shift to ControlzEx HC code #6880

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theming for powertoys run #4007

Theming for powertoys run #4007

dsrivastavv commented Jun 3, 2020 •

edited

Loading

crutkas commented Jun 3, 2020

niels9001 left a comment

dsrivastavv commented Jun 3, 2020

dsrivastavv Jun 3, 2020

niels9001 commented Jun 3, 2020

dsrivastavv commented Jun 3, 2020

alekhyareddy28 left a comment

crutkas commented Jun 5, 2020

niels9001 commented Jun 5, 2020

AnuthaDev commented Jun 5, 2020

dsrivastavv commented Jun 5, 2020

dsrivastavv commented Jun 5, 2020 •

edited

Loading

AnuthaDev commented Jun 5, 2020

AnuthaDev commented Jun 5, 2020

AnuthaDev commented Jun 5, 2020

dsrivastavv commented Jun 5, 2020

AnuthaDev commented Jun 6, 2020

dsrivastavv commented Jun 6, 2020

Theming for powertoys run #4007

Theming for powertoys run #4007

Conversation

dsrivastavv commented Jun 3, 2020 • edited Loading

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Know Issues

Dark Theme

High contrastTheme

LightTheme

crutkas commented Jun 3, 2020

niels9001 left a comment

Choose a reason for hiding this comment

dsrivastavv commented Jun 3, 2020

dsrivastavv Jun 3, 2020

Choose a reason for hiding this comment

niels9001 commented Jun 3, 2020

dsrivastavv commented Jun 3, 2020

alekhyareddy28 left a comment

Choose a reason for hiding this comment

crutkas commented Jun 5, 2020

niels9001 commented Jun 5, 2020

AnuthaDev commented Jun 5, 2020

dsrivastavv commented Jun 5, 2020

dsrivastavv commented Jun 5, 2020 • edited Loading

AnuthaDev commented Jun 5, 2020

AnuthaDev commented Jun 5, 2020

AnuthaDev commented Jun 5, 2020

dsrivastavv commented Jun 5, 2020

AnuthaDev commented Jun 6, 2020

dsrivastavv commented Jun 6, 2020

dsrivastavv commented Jun 3, 2020 •

edited

Loading

dsrivastavv commented Jun 5, 2020 •

edited

Loading