Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with helper emit. #10871

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Fix issue with helper emit. #10871

merged 1 commit into from
Sep 12, 2016

Conversation

rbuckton
Copy link
Member

Helpers are not emit correctly for bundles due to forEach exiting early. This change switches to using for..of to avoid the early exit.

Fixes #10800

@mhegazy
Copy link
Contributor

mhegazy commented Sep 12, 2016

:D

@mhegazy
Copy link
Contributor

mhegazy commented Sep 12, 2016

👍

@rbuckton rbuckton merged commit 439fe79 into master Sep 12, 2016
@rbuckton rbuckton deleted the fix10800 branch September 12, 2016 21:52
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuckton @mhegazy @msftclas