Fix missing final label #10883
Merged
Fix missing final label #10883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit test? |
|
@mhegazy, added the case from the referenced issue. |
|
In the future, adding the test first helps get a before/after picture in the baselines. I usually don't bring it up, but I think it's arguably more important when it comes to the |
|
👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator transformer tries to avoid emitting an unnecessary final
returnstatement if it would be otherwise unreachable. However, the detection logic for this case did not account for the possibility of a preceding break instruction pointing to the final label. This expands on the detection logic for this case.Fixes #10876