Rest of untyped binding pattern is { [s: string]: any } #12564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more correct than any and the code is more elegant as well.
sandersn
changed the title
mhegazy
reviewed
Nov 30, 2016
| @@ -36,3 +36,5 @@ let computed = 'b'; | |||
| let computed2 = 'a'; | |||
| var { [computed]: stillNotGreat, [computed2]: soSo, ...o } = o; | |||
| ({ [computed]: stillNotGreat, [computed2]: soSo, ...o } = o); | |||
|
|
|||
| var noContextualType = ({ aNumber = 12, ...notEmptyObject }) => aNumber; | |||
There was a problem hiding this comment.
can you add a test where notEmptyObject.somePropoerty is used, to make sure we get an error if the behavior changes, instead of just the type-baseline changes.
There was a problem hiding this comment.
also can you add a test for --noImplicitAny error for this case.
There was a problem hiding this comment.
Wait—actually this doesn't allow arbitrary access to properties, just indexed access.
There was a problem hiding this comment.
OK, so I added back the special case. Which makes the two tests you asked for pass.
|
I think this looks much better. |
|
@ahejlsberg any comments? |
sandersn
changed the title
sandersn
changed the title
mhegazy
approved these changes
Dec 1, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12519
Edit:
@mhegazy pointed out that (1) rest of an untyped binding pattern isn't really any since it's definitely not a function (2) adding an index signature results in a more straightforward fix. So the current version adds an index signature to the structurally inferred type of an untyped binding pattern.