Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "completionList" methods instead of "memberList" ones, since they're identical #12730

Merged
1 commit merged into from
Dec 7, 2016
Merged

Use "completionList" methods instead of "memberList" ones, since they're identical #12730

1 commit merged into from
Dec 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2016

Ever since 1fe1913, getMemberListAtCaret and getCompletionListAtCaret have been identical, so we should use only one of them.

@ghost ghost assigned mhegazy Dec 7, 2016
@ghost ghost merged commit b0bbbcb into master Dec 7, 2016
@ghost ghost deleted the memberList_to_completionList branch December 7, 2016 23:34
@mhegazy mhegazy mentioned this pull request Dec 12, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mhegazy mhegazy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @msftclas