Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port generated lib files #19426

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Port generated lib files #19426

merged 1 commit into from
Oct 23, 2017

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Oct 23, 2017

Fixes #19386

@mhegazy mhegazy merged commit a1e3f00 into master Oct 23, 2017
@mhegazy mhegazy deleted the portLibFiles branch October 23, 2017 22:03
@mhegazy mhegazy mentioned this pull request Oct 24, 2017
Merged
sandersn
sandersn reviewed Oct 25, 2017
View reviewed changes
src/lib/webworker.generated.d.ts
declare function addEventListener<K extends keyof DedicatedWorkerGlobalScopeEventMap>(type: K, listener: (this: DedicatedWorkerGlobalScope, ev: DedicatedWorkerGlobalScopeEventMap[K]) => any, useCapture?: boolean): void;
declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
declare function removeEventListener<K extends keyof DedicatedWorkerGlobalScopeEventMap>(type: K, listener: (this: DedicatedWorkerGlobalScope, ev: DedicatedWorkerGlobalScopeEventMap[K]) => any, useCapture?: boolean): void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new overloads have useCapture?: boolean instead of options?: boolean | EventListenerOptions. Why drop EvenListenerOptions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. also addeventListener has the wrong signature. will need to fix them all.

@HolgerJeromin HolgerJeromin mentioned this pull request Oct 26, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @sandersn